From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0768C2D0A3 for ; Fri, 30 Oct 2020 00:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 799152076B for ; Fri, 30 Oct 2020 00:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604017569; bh=PVuEUx7OxZu9aTr2T26kbiAfiPfZsT0Ot66Xi+NQ36U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SOScDq7KmVv0AwwPF+zKso5a1lrtBRo3Hy4fQ/zFN6kgqgMA+dh8M1UV2gB7+5Gul vXSTlLyi2SppyidUxUyVbZ+5z8uao4IXrTEWHzuA9AY8mhlDu13KaInnWsybGf1ERf TpAeto0CynWQLgjLrx8lqVw5xSpfV79KMM1gRCdk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725379AbgJ3A0I (ORCPT ); Thu, 29 Oct 2020 20:26:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:48698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgJ3A0I (ORCPT ); Thu, 29 Oct 2020 20:26:08 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B87A20709; Fri, 30 Oct 2020 00:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604017568; bh=PVuEUx7OxZu9aTr2T26kbiAfiPfZsT0Ot66Xi+NQ36U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LzJWYWIdswRdY1du3F68J/VmtQSOkCd3gCs8gaaSayxtBn/7Vgb7+W6riddb1vJA2 UTfLxdv7tAivslQ5oyLUpEGQGZzued5iUyNlk1xAKgsoD8RRrVJlmgx018y7Egeu/B QO9U2Yhesn13qNJ9yaEmhc0k3i3tOVWMQ+F4Ij1g= Date: Fri, 30 Oct 2020 08:26:01 +0800 From: Shawn Guo To: Krzysztof Kozlowski Cc: Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Adam Ford , Daniel Baluta , Anson Huang , Peter Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Message-ID: <20201030002601.GW28755@dragon> References: <20200927165947.7317-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200927165947.7317-1-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Sep 27, 2020 at 06:59:42PM +0200, Krzysztof Kozlowski wrote: > The PMIC's interrupt is level low and should be pulled up. The PMIC's > device node had pinctrl-0 property but it lacked pinctrl-names which > is required to apply the pin configuration. The actual problem in DTS > was pointed out by Felix Radensky from Variscite. > > Reported-by: Felix Radensky > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags") > Signed-off-by: Krzysztof Kozlowski Applied all, thanks.