From: Shawn Guo <shawnguo@kernel.org>
To: Li Jun <jun.li@nxp.com>
Cc: robh+dt@kernel.org, balbi@kernel.org, krzk@kernel.org,
gregkh@linuxfoundation.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
Anson.Huang@nxp.com, aisheng.dong@nxp.com, peng.fan@nxp.com,
fugang.duan@nxp.com, horia.geanta@nxp.com,
qiangqing.zhang@nxp.com, peter.chen@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/4] add NXP imx8mp usb support
Date: Fri, 30 Oct 2020 15:23:48 +0800 [thread overview]
Message-ID: <20201030072347.GG28755@dragon> (raw)
In-Reply-To: <1601726527-23326-1-git-send-email-jun.li@nxp.com>
On Sat, Oct 03, 2020 at 08:02:03PM +0800, Li Jun wrote:
> NXP imx8MPlus integrates 2 indentical dwc3 3.30b IP with additional wakeup
> logic to support low power, this wakeup logic has a separated interrupt
> which can generate events with suspend clock(32K); due to SoC integration
> limitation, it only can support 32 bits DMA, so add dma-ranges property,
>
> changes for v5
> - Remove "Items" of compatible in binding doc [1/4]
> - Add Krzysztof's R-b tag for patches [3-4/4].
>
> changes for v4:
> - Use dma-ranges property to limit 32bits DMA, so don't need the new
> property "xhci-64bit-support-disable".
> - Fix binding doc to pass dt_binding_check dtbs_check.
>
> changes for v3:
> - Add dwc3 core related clocks into dwc3 core node, and glue layer driver
> only handle the clocks(hsio and suspend) for glue block, this is to
> match real HW.
> - Change to use property "xhci-64bit-support-disable" to disable 64bit DMA
> as imx8mp USB integration actully can't support it, so remove platform
> data in v2.
> - Some changes of imx8mp usb driver binding doc to address comments from Rob
>
> Changes for v2:
> - Drop the 2 patches for new property("snps,xhci-dis-64bit-support-quirk")
> introduction, as suggested, imply by SoC compatible string, this is done
> by introduce dwc3 core platform data and pass the xhci_plat_priv to
> xhci-plat for those xhci quirks, so a new patch added:
> [1/5] usb: dwc3: add platform data to dwc3 core device to pass data.
> this patch is based on Peter's one patch which is also in review:
> https://patchwork.kernel.org/patch/11640945/
> - dts change, use the USB power function of TRL logic instead of a always-on
> regulator to control vbus on/off.
> - Some changes to address Peter's command on patch [2/5].
>
> Li Jun (4):
> dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 glue bindings
> usb: dwc3: add imx8mp dwc3 glue layer driver
> arm64: dtsi: imx8mp: add usb nodes
> arm64: dts: imx8mp-evk: enable usb1 as host mode
The last two dts patches look good to me. Ping me for applying after
the first two are accepted.
Shawn
prev parent reply other threads:[~2020-10-30 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 12:02 [PATCH v5 0/4] add NXP imx8mp usb support Li Jun
2020-10-03 12:02 ` [PATCH v5 1/4] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 glue bindings Li Jun
2020-10-04 13:44 ` Krzysztof Kozlowski
2020-10-06 21:10 ` Rob Herring
2020-10-03 12:02 ` [PATCH v5 2/4] usb: dwc3: add imx8mp dwc3 glue layer driver Li Jun
2020-12-04 2:07 ` Jun Li
2020-10-03 12:02 ` [PATCH v5 3/4] arm64: dtsi: imx8mp: add usb nodes Li Jun
2020-10-03 12:02 ` [PATCH v5 4/4] arm64: dts: imx8mp-evk: enable usb1 as host mode Li Jun
2020-10-30 7:23 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030072347.GG28755@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=peter.chen@nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).