From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
vireshk@kernel.org, robh+dt@kernel.org, nm@ti.com,
rafael@kernel.org, sboyd@kernel.org, daniel.lezcano@linaro.org,
sudeep.holla@arm.com, Dietmar.Eggemann@arm.com
Subject: Re: [PATCH 2/4] OPP: Add support for parsing the 'opp-sustainable' property
Date: Fri, 30 Oct 2020 11:47:50 +0000 [thread overview]
Message-ID: <20201030114750.GA636720@google.com> (raw)
In-Reply-To: <20201028140847.1018-3-lukasz.luba@arm.com>
Hi Lukasz,
On Wednesday 28 Oct 2020 at 14:08:45 (+0000), Lukasz Luba wrote:
> +unsigned long dev_pm_opp_get_sustainable_opp_freq(struct device *dev)
> +{
> + struct opp_table *opp_table;
> + unsigned long freq = 0;
> +
> + opp_table = _find_opp_table(dev);
> + if (IS_ERR(opp_table))
> + return 0;
> +
> + if (opp_table->sustainable_opp && opp_table->sustainable_opp->available)
> + freq = dev_pm_opp_get_freq(opp_table->sustainable_opp);
> +
> + dev_pm_opp_put_opp_table(opp_table);
> +
> + return freq;
> +}
> +EXPORT_SYMBOL_GPL(dev_pm_opp_get_sustainable_opp_freq);
I'm guessing this is what IPA will use to find out what the sustainable
frequency is right?
Is PM_OPP the right place for that? It feels odd IPA will get the EM
from one place, which includes the performance state, and the sustained
OPP from another. Should we move that to PM_EM instead?
Thanks,
Quentin
next prev parent reply other threads:[~2020-10-30 11:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:08 [PATCH 0/4] Add sustainable OPP concept Lukasz Luba
2020-10-28 14:08 ` [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings Lukasz Luba
2020-10-28 21:47 ` Nishanth Menon
2020-10-29 10:04 ` Lukasz Luba
2020-10-29 12:59 ` Nishanth Menon
2020-10-29 13:33 ` Lukasz Luba
2020-10-29 13:49 ` Nishanth Menon
2020-10-29 14:20 ` Lukasz Luba
2020-10-30 19:34 ` Rob Herring
2020-11-02 8:40 ` Lukasz Luba
2020-10-28 14:08 ` [PATCH 2/4] OPP: Add support for parsing the 'opp-sustainable' property Lukasz Luba
2020-10-30 11:47 ` Quentin Perret [this message]
2020-10-30 12:53 ` Lukasz Luba
2020-10-28 14:08 ` [PATCH 3/4] OPP: Add dev_pm_opp_set_sustainable_opp_freq() Lukasz Luba
2020-10-28 14:08 ` [PATCH 4/4] firmware: arm_scmi/perf: Mark sustainable OPP Lukasz Luba
2020-10-29 7:40 ` [PATCH 0/4] Add sustainable OPP concept Viresh Kumar
2020-10-29 7:53 ` Viresh Kumar
2020-10-29 9:56 ` Lukasz Luba
2020-10-30 8:29 ` Viresh Kumar
2020-10-30 9:19 ` Lukasz Luba
2020-10-30 9:52 ` Viresh Kumar
2020-10-30 10:56 ` Lukasz Luba
2020-10-30 11:17 ` Viresh Kumar
2020-10-30 12:40 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030114750.GA636720@google.com \
--to=qperret@google.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).