From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE465C2D0A3 for ; Sun, 1 Nov 2020 13:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D82F2225C for ; Sun, 1 Nov 2020 13:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbgKAN0C convert rfc822-to-8bit (ORCPT ); Sun, 1 Nov 2020 08:26:02 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:59513 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbgKAN0C (ORCPT ); Sun, 1 Nov 2020 08:26:02 -0500 X-Greylist: delayed 158304 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Nov 2020 08:26:00 EST Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 9D372200006; Sun, 1 Nov 2020 13:25:58 +0000 (UTC) Date: Sun, 1 Nov 2020 14:25:57 +0100 From: Miquel Raynal To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Jonathan Cameron , Philippe Reynes Subject: Re: [PATCH 07/10] dt-bindings:iio:adc:maxim,max1027: Pull out to separate binding doc. Message-ID: <20201101142557.153c7b97@xps13> In-Reply-To: <20201031181242.742301-8-jic23@kernel.org> References: <20201031181242.742301-1-jic23@kernel.org> <20201031181242.742301-8-jic23@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jonathan, Jonathan Cameron wrote on Sat, 31 Oct 2020 18:12:39 +0000: > From: Jonathan Cameron > > The afe/voltage-divider.yaml example uses this device with 2 properties > not provided by trivial-devices.yaml (spi-max-frequency and #io-channel-cells) > > Solve that by creating a more specific binding doc. I don't know #io-channel-cells but spi-max-frequency is very common and is related to the fact that this device is a SPI device (hence, a SPI subnode), IMHO it has nothing to do with trivial-devices.yaml description. > > Signed-off-by: Jonathan Cameron > Cc: Miquel Raynal > Cc: Philippe Reynes > --- > .../bindings/iio/adc/maxim,max1027.yaml | 64 +++++++++++++++++++ > .../devicetree/bindings/trivial-devices.yaml | 12 ---- > 2 files changed, 64 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1027.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1027.yaml > new file mode 100644 > index 000000000000..09e853c50c76 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1027.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/maxim,max1027.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX1027 and similar ADCs > + > +maintainers: > + - Miquel Raynal > + - Philippe Reynes > + > +description: | > + 300ks/s SPI ADCs with temperature sensors. > + > +properties: > + compatible: > + enum: > + # 10-bit 8 channels > + - maxim,max1027 > + # 10-bit 12 channels > + - maxim,max1029 > + # 10-bit 16 channels > + - maxim,max1031 > + # 12-bit 8 channels > + - maxim,max1227 > + # 12-bit 12 channels > + - maxim,max1229 > + # 12-bit 16 channels > + - maxim,max1231 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + spi-max-frequency: true > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + maxadc: adc@0 { > + compatible = "maxim,max1027"; > + reg = <0>; > + #io-channel-cells = <1>; > + interrupt-parent = <&gpio5>; > + interrupts = <15 IRQ_TYPE_EDGE_RISING>; > + spi-max-frequency = <1000000>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index d154ea97e30d..185e09e61e16 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -108,18 +108,6 @@ properties: > - isil,isl68137 > # 5 Bit Programmable, Pulse-Width Modulator > - maxim,ds1050 > - # 10-bit 8 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1027 > - # 10-bit 12 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1029 > - # 10-bit 16 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1031 > - # 12-bit 8 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1227 > - # 12-bit 12 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1229 > - # 12-bit 16 channels 300ks/s SPI ADC with temperature sensor > - - maxim,max1231 > # Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs > - maxim,max1237 > # PECI-to-I2C translator for PECI-to-SMBus/I2C protocol conversion Thanks, Miquèl