devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
	shawnguo@kernel.org, robh+dt@kernel.org
Cc: paul.kocialkowski@bootlin.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	s.hauer@pengutronix.de, aisheng.dong@nxp.com,
	daniel.baluta@nxp.com, robert.chiras@nxp.com,
	laurentiu.palcu@nxp.com, mark.rutland@arm.com,
	devicetree@vger.kernel.org, p.zabel@pengutronix.de,
	ezequiel@collabora.com,
	laurent.pinchart+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se,
	dafna.hirschfeld@collabora.com,
	Mirela Rabulea <mirela.rabulea@nxp.com>
Subject: [PATCH v4 07/11] media: imx-jpeg: Fix v4l2-compliance streaming tests on decoder
Date: Mon,  2 Nov 2020 05:08:17 +0200	[thread overview]
Message-ID: <20201102030821.3049-8-mirela.rabulea@oss.nxp.com> (raw)
In-Reply-To: <20201102030821.3049-1-mirela.rabulea@oss.nxp.com>

From: Mirela Rabulea <mirela.rabulea@nxp.com>

Streaming tests were faling on decoder, due to errors on
jpeg parse. Let the error be, until device_run, there
check for errors and finish job.

Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
 drivers/media/platform/imx-jpeg/mxc-jpeg.c | 25 ++++++++++++++++------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
index 8535da246a63..d87f99caf124 100644
--- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
@@ -249,6 +249,7 @@ struct mxc_jpeg_src_buf {
 
 	/* mxc-jpeg specific */
 	bool			dht_needed;
+	bool			jpeg_parse_error;
 };
 
 static inline struct mxc_jpeg_src_buf *vb2_to_mxc_buf(struct vb2_buffer *vb)
@@ -929,6 +930,7 @@ static void mxc_jpeg_device_run(void *priv)
 	struct vb2_v4l2_buffer *src_buf, *dst_buf;
 	unsigned long flags;
 	struct mxc_jpeg_q_data *q_data_cap, *q_data_out;
+	struct mxc_jpeg_src_buf *jpeg_src_buf;
 
 	spin_lock_irqsave(&ctx->mxc_jpeg->hw_lock, flags);
 	src_buf = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
@@ -949,6 +951,19 @@ static void mxc_jpeg_device_run(void *priv)
 
 	v4l2_m2m_buf_copy_metadata(src_buf, dst_buf, true);
 
+	jpeg_src_buf = vb2_to_mxc_buf(&src_buf->vb2_buf);
+	if (jpeg_src_buf->jpeg_parse_error) {
+		jpeg->slot_data[ctx->slot].used = false;
+		v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+		v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
+		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
+		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR);
+		spin_unlock_irqrestore(&ctx->mxc_jpeg->hw_lock, flags);
+		v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx);
+
+		return;
+	}
+
 	/*
 	 * TODO: this reset should be removed, once we figure out
 	 * how to overcome hardware issues both on encoder and decoder
@@ -1483,17 +1498,13 @@ static void mxc_jpeg_buf_queue(struct vb2_buffer *vb)
 		goto end;
 
 	jpeg_src_buf = vb2_to_mxc_buf(vb);
+	jpeg_src_buf->jpeg_parse_error = false;
 	ret = mxc_jpeg_parse(ctx,
 			     (u8 *)vb2_plane_vaddr(vb, 0),
 			     vb2_get_plane_payload(vb, 0),
 			     &jpeg_src_buf->dht_needed);
-	if (ret) {
-		v4l2_err(&ctx->mxc_jpeg->v4l2_dev,
-			 "driver does not support this resolution/format\n");
-		vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
-
-		return;
-	}
+	if (ret)
+		jpeg_src_buf->jpeg_parse_error = true;
 
 end:
 	v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
-- 
2.17.1


  parent reply	other threads:[~2020-11-02  3:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  3:08 [PATCH v4 00/11] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 01/11] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 02/11] firmware: imx: scu-pd: Add power domains for imx-jpeg Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 03/11] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea (OSS)
2020-11-04 22:38   ` Rob Herring
2020-11-09 21:59     ` [EXT] " Mirela Rabulea
2020-11-02  3:08 ` [PATCH v4 04/11] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-02 16:20   ` Laurentiu Palcu
2020-11-06  1:05     ` Mirela Rabulea
2020-11-02  3:08 ` [PATCH v4 05/11] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 06/11] Add maintainer for IMX jpeg v4l2 driver Mirela Rabulea (OSS)
2020-11-02 16:25   ` Laurentiu Palcu
2020-11-02  3:08 ` Mirela Rabulea (OSS) [this message]
2020-11-02  3:08 ` [PATCH v4 08/11] media: Add parsing for APP14 data segment in jpeg helpers Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 09/11] media: Quit parsing stream if doesn't start with SOI Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 10/11] media: Avoid parsing quantization and huffman tables Mirela Rabulea (OSS)
2020-11-02  3:08 ` [PATCH v4 11/11] media: imx-jpeg: Use v4l2 jpeg helpers in mxc-jpeg Mirela Rabulea (OSS)
2020-11-04 11:52 ` [PATCH v4 00/11] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Hans Verkuil
2020-11-04 11:55   ` Hans Verkuil
2020-11-04 13:27     ` [EXT] " Mirela Rabulea
2020-11-04 14:08       ` Hans Verkuil
2020-11-06  1:04         ` Mirela Rabulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102030821.3049-8-mirela.rabulea@oss.nxp.com \
    --to=mirela.rabulea@oss.nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.palcu@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=mirela.rabulea@nxp.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robert.chiras@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).