From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Luka Kovacic <luka.kovacic@sartura.hr>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-hwmon@vger.kernel.org,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Marek Behun <marek.behun@nic.cz>,
Luka Perkov <luka.perkov@sartura.hr>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU
Date: Mon, 2 Nov 2020 20:03:35 +0100 [thread overview]
Message-ID: <20201102190335.GA25451@duo.ucw.cz> (raw)
In-Reply-To: <7821443b-ddbc-fc92-b990-14d116dda853@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
On Mon 2020-11-02 12:29:59, Dan Murphy wrote:
> Hello
>
> On 11/1/20 3:56 AM, Luka Kovacic wrote:
> > Hello Pavel,
> >
> > On Thu, Oct 29, 2020 at 7:01 PM Pavel Machek <pavel@ucw.cz> wrote:
> > > Hi!
> > >
> > > > +What: /sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/power_status
> > > > +Date: September 2020
> > > > +Contact: Luka Kovacic <luka.kovacic@sartura.hr>
> > > > +Description: (RO) Power status indicates the host platform power on method.
> > > > + Value mapping (bitwise list):
> > > > + 0x80 - Null
> > > > + 0x40 - Firmware flag
> > > > + 0x20 - Power loss detection flag (powered off)
> > > > + 0x10 - Power loss detection flag (AC mode)
> > > > + 0x08 - Button power on
> > > > + 0x04 - WOL power on
> > > > + 0x02 - RTC alarm power on
> > > > + 0x01 - AC recover power on
> > > It would be nice to put this into standard place somewhere. Many
> > > machines will want to expose this information.
> > As this is specific to this microcontroller and to how it encodes
> > these values, I don't see a need to change this.
> > This isn't used anywhere else.
> >
> > > If not, at least spell out WoL, as it is not that common of acronym.
> > Okay.
>
> WoL is a very common acronym especially in the networking space
WoL is common. WOL is not. Better spell it out.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-11-02 19:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 0:59 [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU Luka Kovacic
2020-10-25 0:59 ` [PATCH v7 1/6] dt-bindings: Add IEI vendor prefix and IEI WT61P803 PUZZLE driver bindings Luka Kovacic
2020-10-28 15:15 ` Rob Herring
2020-11-01 9:45 ` Luka Kovacic
2020-10-25 0:59 ` [PATCH v7 2/6] drivers: mfd: Add a driver for IEI WT61P803 PUZZLE MCU Luka Kovacic
2020-10-26 22:54 ` Andy Shevchenko
2020-11-01 13:22 ` Luka Kovacic
2020-11-02 11:19 ` Andy Shevchenko
2020-11-02 23:15 ` Luka Kovacic
2020-11-03 9:27 ` Andy Shevchenko
2020-10-25 0:59 ` [PATCH v7 3/6] drivers: hwmon: Add the IEI WT61P803 PUZZLE HWMON driver Luka Kovacic
2020-11-08 16:51 ` Guenter Roeck
2020-11-10 20:06 ` Luka Kovacic
2020-10-25 0:59 ` [PATCH v7 4/6] drivers: leds: Add the IEI WT61P803 PUZZLE LED driver Luka Kovacic
2020-10-29 17:58 ` Pavel Machek
2020-11-01 9:34 ` Luka Kovacic
2020-10-25 0:59 ` [PATCH v7 5/6] Documentation/ABI: Add iei-wt61p803-puzzle driver sysfs interface documentation Luka Kovacic
2020-10-25 0:59 ` [PATCH v7 6/6] MAINTAINERS: Add an entry for the IEI WT61P803 PUZZLE driver Luka Kovacic
2020-10-29 18:01 ` [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU Pavel Machek
2020-11-01 9:56 ` Luka Kovacic
2020-11-02 18:29 ` Dan Murphy
2020-11-02 19:03 ` Pavel Machek [this message]
2020-11-02 19:04 ` Dan Murphy
2020-11-02 22:36 ` Luka Kovacic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102190335.GA25451@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luka.kovacic@sartura.hr \
--cc=luka.perkov@sartura.hr \
--cc=marek.behun@nic.cz \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).