From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22EDC2D0A3 for ; Tue, 3 Nov 2020 22:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E5A3223C7 for ; Tue, 3 Nov 2020 22:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604443481; bh=B0hofVyjbIarQN5JcfzWbRMadJujwsK3/oEFwLCaHaE=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=gGNkM/RaHdVmKaQZS1R6BctFTYB5T6SU7oJfm5E5ihX7RkEJV7ZuvvoZnYKzablRw EXc5DmLrntzYMf4yf2jQuM4CmT+o6AxWWsl/koV7FRP2qrF50aIeoI7asLj9uznTd1 uTs8pqSRYgikZoL90bGckt5AwJCnskgPyO7AN6M8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730672AbgKCWok (ORCPT ); Tue, 3 Nov 2020 17:44:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:35078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730606AbgKCWok (ORCPT ); Tue, 3 Nov 2020 17:44:40 -0500 Received: from localhost (230.sub-72-107-127.myvzw.com [72.107.127.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4779F21534; Tue, 3 Nov 2020 22:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604443479; bh=B0hofVyjbIarQN5JcfzWbRMadJujwsK3/oEFwLCaHaE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=aGJthRPHhGnUHt1ZdKqRmEtO85M2aHQ0EeBOkvpHEdxgqcV5i3Ard2wiJ81JAWc/6 kqheh439OJUiLwEjikfrm/596btquk1VT+KMzM6CPVKq/RwToIlXTv8sbNUy6UTy0i BatF/rWkEZdP538Vqd3i+3FwP4h+TInyIqmAjSB8= Date: Tue, 3 Nov 2020 16:44:37 -0600 From: Bjorn Helgaas To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jaehoon Chung , Jingoo Han , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , Vinod Koul , Kishon Vijay Abraham I , Rob Herring Subject: Re: [PATCH v3 0/6] Add DW PCIe support for Exynos5433 SoCs Message-ID: <20201103224437.GA271545@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029134017.27400-1-m.szyprowski@samsung.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 29, 2020 at 02:40:11PM +0100, Marek Szyprowski wrote: > Dear All, > > This patchset is a resurrection of the DW PCIe support for the Exynos5433 > SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and > later here: https://lkml.org/lkml/2017/12/21/296 . > > In meantime the support for the Exynos5440 SoCs has been completely > dropped from mainline kernel, as those SoCs never reached the market. The > PCIe driver for Exynos5440 variant however has not been removed yet. This > patchset simply reworks it to support the Exynos5433 variant. The lack of > the need to support both variants significantly simplifies the driver > code. > > This patchset is based on the following branch: > git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-more-dwc-cleanup > > Best regards, > Marek Szyprowski > > > Changelog: > > v3: > - rebased onto "[00/13] PCI: dwc: Another round of clean-ups" patchset: > https://patchwork.kernel.org/project/linux-samsung-soc/cover/20201028204646.356535-1-robh@kernel.org/ > - fixed issues pointed by Rob in the driver logic: > * removed DBI_RO_WR_EN register poking > * made driver a standard module > - fixed section mismatch issue > - added "num-viewport = <3>" property to dts and bindings to fix warning > > v2: https://lore.kernel.org/linux-samsung-soc/20201023075744.26200-1-m.szyprowski@samsung.com/ > - fixed issues in dt-bindings pointed by Krzysztof and Rob > > v1: https://lore.kernel.org/linux-samsung-soc/20201019094715.15343-1-m.szyprowski@samsung.com/ > - initial version of this resurrected patchset > > > Patch summary: Please follow the subject line convention: PCI: exynos: Rework to support Exynos5433 variant arm64: dts: exynos: Add WiFi/PCIe support to TM2(e) boards dt-bindings: PCI: exynos: Drop samsung,exynos5440-pcie binding dt-bindings: PCI: exynos: Add samsung,exynos-pcie binding dt-bindings: phy: exynos: Add samsung,exynos-pcie-phy binding You can save this trouble by running "git log --oneline" on the file (or directory, for new files) and copying the style. > Jaehoon Chung (3): > phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 > PCIe PHY > pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant > arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards > > Marek Szyprowski (3): > dt-bindings: pci: drop samsung,exynos5440-pcie binding > dt-bindings: pci: add the samsung,exynos-pcie binding > dt-bindings: phy: add the samsung,exynos-pcie-phy binding > > .../bindings/pci/samsung,exynos-pcie.yaml | 119 ++++++ > .../bindings/pci/samsung,exynos5440-pcie.txt | 58 --- > .../bindings/phy/samsung,exynos-pcie-phy.yaml | 51 +++ > .../boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- > .../dts/exynos/exynos5433-tm2-common.dtsi | 24 +- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 36 ++ > drivers/pci/controller/dwc/Kconfig | 10 +- > drivers/pci/controller/dwc/pci-exynos.c | 353 +++++++----------- > drivers/pci/quirks.c | 1 + > drivers/phy/samsung/phy-exynos-pcie.c | 304 ++++++--------- > 10 files changed, 489 insertions(+), 469 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > delete mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml > > -- > 2.17.1 >