From: Alexander Dahl <post@lespocky.de>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Alexander Dahl <ada@thorsis.com>,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
Date: Mon, 9 Nov 2020 23:21:49 +0100 [thread overview]
Message-ID: <20201109222149.bnhjpytdvo4en2mf@falbala.internal.home.lespocky.de> (raw)
In-Reply-To: <eef76d72-7467-eed7-ac65-93237bd2b3bb@st.com>
[-- Attachment #1: Type: text/plain, Size: 4596 bytes --]
Hello Alex,
On Mon, Nov 09, 2020 at 12:02:18PM +0100, Alexandre Torgue wrote:
> Hi Alex
>
> On 10/31/20 2:54 PM, Alexander Dahl wrote:
> > Hei hei,
> >
> > On Tue, Oct 27, 2020 at 11:58:10AM +0100, Ahmad Fatoum wrote:
> > > Hello,
> > >
> > > On 10/27/20 11:05 AM, Alexander Dahl wrote:
> > > > Hello Ahmad,
> > > >
> > > > thanks for your feedback, comments below.
> > > >
> > >
> > > > > > - led-rgb {
> > > > > > + led-controller-2 {
> > > > >
> > > > > Is a single RGB LED really a controller?
> > > >
> > > > I just followed the recommendations by Rob here.
> > >
> > > Do you happen to know if the new multicolor LED support could be used here?
> > >
> > > I find it unfortunate that the device tree loses information relevant to humans
> > > to adhere to a fixed nomenclature. Apparently led-controller isn't even codified
> > > in the YAML binding (It's just in the examples). If you respin, please add a
> > > comment that this is a single RGB led. I'd prefer to keep the information
> > > in the DTB as well though.
> >
> > Slightly off-topic, but while I was working on the patch based on your
> > feedback I tried to find some information on that Linux Automation
> > MC-1 board. However I could not find any? Is there some website, some
> > datasheet or maybe a schematic online? The vendor prefix says "Linux
> > Automation GmbH", but I find only that USB-SD-Mux on their page?
> >
> > Greets
> > Alex
>
> I saw that Ahmad Acked this patch but regarding your discussion it seems
> there are opening questions. Are you going to send an update of it or can I
> take it ?
I'll send an update, I already reworked this patch. I'm still waiting
for an Ack for the first patch of the series before sending the next
iteration, though. :-/
Greets
Alex
>
> regards
> alex
>
>
>
> >
> > >
> > >
> > >
> > > >
> > > > > > compatible = "pwm-leds";
> > > > > > - led-red {
> > > > > > + led-2 {
> > > > >
> > > > > Shouldn't this have been led-1 as well or is the numbering "global" ?
> > > >
> > > > Also good question. This numbering is for dts only, it usually does
> > > > not correspond with LEDs on the board, so it could be numbered per
> > > > led-controller as well?
> > >
> > > I'd prefer that it starts by 1. That way it's aligned with PWM channel
> > > ID.
> > >
> > > Thanks for fixing the dtschema warnings by the way!
> > >
> > > Cheers,
> > > Ahmad
> > >
> > > >
> > > > Greets
> > > > Alex
> > > >
> > > > >
> > > > > > label = "mc1:red:rgb";
> > > > > > pwms = <&leds_pwm 1 1000000 0>;
> > > > > > max-brightness = <255>;
> > > > > > active-low;
> > > > > > };
> > > > > > - led-green {
> > > > > > + led-3 {
> > > > > > label = "mc1:green:rgb";
> > > > > > pwms = <&leds_pwm 2 1000000 0>;
> > > > > > max-brightness = <255>;
> > > > > > active-low;
> > > > > > };
> > > > > > - led-blue {
> > > > > > + led-4 {
> > > > > > label = "mc1:blue:rgb";
> > > > > > pwms = <&leds_pwm 3 1000000 0>;
> > > > > > max-brightness = <255>;
> > > > > >
> > > > >
> > > > > --
> > > > > Pengutronix e.K. | |
> > > > > Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> > > > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> > > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> > > >
> > >
> > > --
> > > Pengutronix e.K. | |
> > > Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> >
> >
> > _______________________________________________
> > Linux-stm32 mailing list
> > Linux-stm32@st-md-mailman.stormreply.com
> > https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-09 22:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
2020-10-07 10:03 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-07 10:02 ` Pavel Machek
2020-10-07 10:03 ` Krzysztof Kozlowski
2020-10-28 20:39 ` Alexander Dahl
2020-10-29 13:46 ` Russell King - ARM Linux admin
2020-11-25 11:08 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-06 2:17 ` Jeff LaBundy
2020-10-06 6:34 ` Alexander Dahl
2020-10-06 22:27 ` Rob Herring
2020-10-06 22:28 ` Rob Herring
2020-10-07 10:03 ` Pavel Machek
2020-10-07 10:08 ` Alexander Dahl
2020-10-08 7:33 ` Lee Jones
2020-10-08 7:50 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
2020-10-07 6:25 ` Krzysztof Kozlowski
2020-10-26 18:45 ` Krzysztof Kozlowski
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
2020-10-30 7:46 ` Shawn Guo
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
2020-11-10 13:25 ` Tony Lindgren
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
2020-10-27 7:03 ` [Linux-stm32] " Ahmad Fatoum
2020-10-27 10:05 ` Alexander Dahl
2020-10-27 10:58 ` Ahmad Fatoum
2020-10-28 7:34 ` Alexander Dahl
2020-11-02 10:47 ` Ahmad Fatoum
2020-10-31 13:54 ` Alexander Dahl
2020-11-02 11:10 ` Ahmad Fatoum
2020-11-09 11:02 ` Alexandre Torgue
2020-11-09 22:21 ` Alexander Dahl [this message]
2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
2020-10-28 19:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109222149.bnhjpytdvo4en2mf@falbala.internal.home.lespocky.de \
--to=post@lespocky.de \
--cc=a.fatoum@pengutronix.de \
--cc=ada@thorsis.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).