From: Shawn Guo <shawnguo@kernel.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: imx50-kobo-aura: Enable eKTF2132 touchscreen
Date: Tue, 10 Nov 2020 11:12:52 +0800 [thread overview]
Message-ID: <20201110031251.GZ31601@dragon> (raw)
In-Reply-To: <20201106112412.390724-4-j.neuschaefer@gmx.net>
On Fri, Nov 06, 2020 at 12:24:12PM +0100, Jonathan Neuschäfer wrote:
> The Kobo Aura has an eKTF2132 touchscreen controller.
>
> Although the vendor kernel toggles a reset pin (GPIO5-12) during the
> startup sequence, the touchscreen works without it.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> This patch requires "[PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix
> to pinctrl node names" in order to apply cleanly.
> (https://lore.kernel.org/lkml/20201031210729.2804471-1-j.neuschaefer@gmx.net/)
> ---
> arch/arm/boot/dts/imx50-kobo-aura.dts | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts
> index b2fbee60271f2..82ce8c43be867 100644
> --- a/arch/arm/boot/dts/imx50-kobo-aura.dts
> +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts
> @@ -120,7 +120,14 @@ &i2c1 {
> pinctrl-0 = <&pinctrl_i2c1>;
> status = "okay";
>
> - /* TODO: ektf2132 touch controller at 0x15 */
> + touchscreen@15 {
> + reg = <0x15>;
> + compatible = "elan,ektf2132";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ts>;
> + power-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>;
> + interrupts-extended = <&gpio5 13 IRQ_TYPE_EDGE_FALLING>;
It needs include of <dt-bindings/interrupt-controller/irq.h>.
DTC arch/arm/boot/dts/imx50-kobo-aura.dtb
Error: ../arch/arm/boot/dts/imx50-kobo-aura.dts:128.36-37 syntax error
FATAL ERROR: Unable to parse input tree
scripts/Makefile.lib:326: recipe for target 'arch/arm/boot/dts/imx50-kobo-aura.dtb' failed
make[2]: *** [arch/arm/boot/dts/imx50-kobo-aura.dtb] Error 1
Patch dropped.
Shawn
> + };
> };
>
> &i2c2 {
> @@ -240,6 +247,13 @@ MX50_PAD_SD3_D7__ESDHC3_DAT7 0x1d4
> >;
> };
>
> + pinctrl_ts: tsgrp {
> + fsl,pins = <
> + MX50_PAD_CSPI_MOSI__GPIO4_9 0x0
> + MX50_PAD_SD2_D5__GPIO5_13 0x0
> + >;
> + };
> +
> pinctrl_uart2: uart2grp {
> fsl,pins = <
> MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-11-10 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 11:24 [PATCH 0/3] Support for ELAN eKTF2132 touchscreens Jonathan Neuschäfer
2020-11-06 11:24 ` [PATCH 1/3] dt-bindings: input: ektf2127: Add elan,ektf2132 compatible string Jonathan Neuschäfer
2020-11-09 2:30 ` Dmitry Torokhov
2020-11-06 11:24 ` [PATCH 2/3] Input: ektf2127 - Add support for eKTF2132 touchscreen Jonathan Neuschäfer
2020-11-09 2:30 ` Dmitry Torokhov
2020-11-06 11:24 ` [PATCH 3/3] ARM: dts: imx50-kobo-aura: Enable " Jonathan Neuschäfer
2020-11-10 2:35 ` Shawn Guo
2020-11-10 3:12 ` Shawn Guo [this message]
2020-11-10 8:25 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110031251.GZ31601@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=j.neuschaefer@gmx.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).