From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31492C4742C for ; Fri, 13 Nov 2020 09:22:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEE9F22244 for ; Fri, 13 Nov 2020 09:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgKMJWI (ORCPT ); Fri, 13 Nov 2020 04:22:08 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:49557 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgKMJWI (ORCPT ); Fri, 13 Nov 2020 04:22:08 -0500 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 64DEB240017; Fri, 13 Nov 2020 09:22:05 +0000 (UTC) Date: Fri, 13 Nov 2020 10:22:05 +0100 From: Alexandre Belloni To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Jonathan Cameron , Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH 29/46] dt-bindings:iio:adc:atmel,sama9260-adc: conversion to yaml from at91_adc.txt Message-ID: <20201113092205.GH4556@piout.net> References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-30-jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031184854.745828-30-jic23@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/10/2020 18:48:37+0000, Jonathan Cameron wrote: > From: Jonathan Cameron > > This binding raises a few questions. > 1) Do we need #address-cells and #size-cells as the child nodes don't have > a reg property? A few dtsi files include these so if we drop the > requirement we will need to clean those up as well. You can drop them. > 2) Renamed to a specific part. Given we have another at91 ADC binding > it is clear now this won't cover all at91 parts so lets name it > after a specific part. > 3) For atmel,adc-res-names the description is a big vague. Are other > resolution names allowed? We don't seem to have any currently. > I had a look and this is a legacy mess, I'll send a fix soon. > There are a few things we would do differently in an ADC binding if we > were starting from scratch but we are stuck with what we have (which > made sense back when this was written!) > > We may be able to tighten up some elements of this binding in the future > by careful checking of what values properties can actually take. > Is there anything generic to select the resolution? I'll be happy to remove atmel,adc-res-names, atmel,adc-res and atmel,adc-use-res as there is no upstream users and the default is to use the highest resolution. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com