From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A20CC5519F for ; Sun, 22 Nov 2020 16:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 528362078D for ; Sun, 22 Nov 2020 16:59:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IA2hXFva" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbgKVQ7B (ORCPT ); Sun, 22 Nov 2020 11:59:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:56600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgKVQ7B (ORCPT ); Sun, 22 Nov 2020 11:59:01 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD9AF20781; Sun, 22 Nov 2020 16:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606064340; bh=B889S553gd5zgqPN+YPleK+3bmcP0GwlN3iQqif4ZxA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IA2hXFvaLck2r5F18MKPPZH5CEkBJBrJGjkFXkPzbOiv5814y/+V/FF+SUoIRWOhG oCWuYWPhdl+or1DWC0N8koow0xHzZSeSX84vu7RQV6ZvkYE+h5Iy0fPGTYbCSK3oIW ilT5Tb8ryZsHV/2P7G9mYQNfd+HntU5lv7hNV6cA= Date: Sun, 22 Nov 2020 16:58:56 +0000 From: Jonathan Cameron To: Matt Ranostay Cc: "open list:IIO SUBSYSTEM AND DRIVERS" , Rob Herring , devicetree@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH 09/46] dt-bindings:iio:health:maxim,max30100: txt to yaml conversion Message-ID: <20201122165856.265d4cb6@archlinux> In-Reply-To: References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-10-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 31 Oct 2020 14:41:56 -0700 Matt Ranostay wrote: > On Sat, Oct 31, 2020 at 11:51 AM Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > Straight forward conversion. As with other bindings I've dropped > > any standrd description, but kept the unusual bits, in thisscase > > the maxim,led-current-microamp and it's description. > > > > Signed-off-by: Jonathan Cameron > > --- > > .../bindings/iio/health/max30100.txt | 28 ---------- > > .../bindings/iio/health/maxim,max30100.yaml | 52 +++++++++++++++++++ > > 2 files changed, 52 insertions(+), 28 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/health/max30100.txt b/Documentation/devicetree/bindings/iio/health/max30100.txt > > deleted file mode 100644 > > index 0054908a6e74..000000000000 > > --- a/Documentation/devicetree/bindings/iio/health/max30100.txt > > +++ /dev/null > > @@ -1,28 +0,0 @@ > > -Maxim MAX30100 heart rate and pulse oximeter sensor > > - > > -* https://datasheets.maximintegrated.com/en/ds/MAX30100.pdf > > - > > -Required properties: > > - - compatible: must be "maxim,max30100" > > - - reg: the I2C address of the sensor > > - - interrupts: the sole interrupt generated by the device > > - > > - Refer to interrupt-controller/interrupts.txt for generic > > - interrupt client node bindings. > > - > > -Optional properties: > > - - maxim,led-current-microamp: configuration for LED current in microamperes > > - while the engine is running. First indexed value is the configuration for > > - the RED LED, and second value is for the IR LED. > > - > > - Refer to the datasheet for the allowed current values. > > - > > -Example: > > - > > -max30100@57 { > > - compatible = "maxim,max30100"; > > - reg = <0x57>; > > - maxim,led-current-microamp = <24000 50000>; > > - interrupt-parent = <&gpio1>; > > - interrupts = <16 2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml > > new file mode 100644 > > index 000000000000..5684f2f61bcc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/health/maxim,max30100.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim MAX30100 heart rate and pulse oximeter sensor > > + > > +maintainers: > > + - Matt Ranostay > > Please change to my Konsulko email, but otherwise LGTM > > Acked-by: Matt Ranostay Fixed and also dropped the $ref for the *microamp item below as that's already covered by dt-schema as Rob pointed out for another occurrence. Applied to the togreg branch of iio.git and pushed out as testing for all the normal reasons. Thanks, Jonathan > > > + > > +properties: > > + compatible: > > + const: maxim,max30100 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + description: Connected to ADC_RDY pin. > > + > > + maxim,led-current-microamp: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 2 > > + maxItems: 2 > > + description: | > > + LED current whilst the engine is running. First indexed value is > > + the configuration for the RED LED, and second value is for the IR LED. > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + heart-rate@57 { > > + compatible = "maxim,max30100"; > > + reg = <0x57>; > > + maxim,led-current-microamp = <24000 50000>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <16 2>; > > + }; > > + }; > > +... > > -- > > 2.28.0 > >