From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F94AC5519F for ; Sun, 22 Nov 2020 18:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D21B20760 for ; Sun, 22 Nov 2020 18:44:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbgKVSoN (ORCPT ); Sun, 22 Nov 2020 13:44:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbgKVSoN (ORCPT ); Sun, 22 Nov 2020 13:44:13 -0500 Received: from saturn.retrosnub.co.uk (saturn.retrosnub.co.uk [IPv6:2a00:1098:86::1:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2EABC0613CF; Sun, 22 Nov 2020 10:44:12 -0800 (PST) Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 04E529E0039; Sun, 22 Nov 2020 18:44:10 +0000 (GMT) Date: Sun, 22 Nov 2020 18:44:08 +0000 From: Jonathan Cameron To: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Cc: Jonathan Cameron Subject: Re: [PATCH 40/46] dt-bindings:iio:accel:bosch,bma180: txt to yaml format conversion. Message-ID: <20201122184408.36b65770@archlinux> In-Reply-To: <20201031184854.745828-41-jic23@kernel.org> References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-41-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 31 Oct 2020 18:48:48 +0000 Jonathan Cameron wrote: > From: Jonathan Cameron > > One question in here is whether we want to constrain the number of > interrupts. Some parts definitely only have 1 such pin, and others > 2 pins but I can not find information on the bma254. > > Signed-off-by: Jonathan Cameron > Cc: Oleksandr Kravchenko Olkesandr's email address is bouncing so I've listed myself as maintainer for now. Applied. Thanks, Jonathan > --- > .../devicetree/bindings/iio/accel/bma180.txt | 35 ----------- > .../bindings/iio/accel/bosch,bma180.yaml | 62 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 35 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt > deleted file mode 100644 > index 33da4a6fdb39..000000000000 > --- a/Documentation/devicetree/bindings/iio/accel/bma180.txt > +++ /dev/null > @@ -1,35 +0,0 @@ > -* Bosch BMA023 / BMA150/ BMA180 / BMA25x / SMB380 triaxial acceleration sensor > - > -https://media.digikey.com/pdf/Data%20Sheets/Bosch/BMA150.pdf > -http://omapworld.com/BMA180_111_1002839.pdf > -http://ae-bst.resource.bosch.com/media/products/dokumente/bma250/bst-bma250-ds002-05.pdf > - > -Required properties: > - > - - compatible : should be one of: > - "bosch,bma023" > - "bosch,bma150" > - "bosch,bma180" > - "bosch,bma250" > - "bosch,bma254" > - "bosch,smb380" > - - reg : the I2C address of the sensor > - - vdd-supply : regulator phandle connected to the VDD pin > - - vddio-supply : regulator phandle connected to the VDDIO pin > - > -Optional properties: > - > - - interrupts : interrupt mapping for GPIO IRQ, it should by configured with > - flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING > - For the bma250 the first interrupt listed must be the one > - connected to the INT1 pin, the second (optional) interrupt > - listed must be the one connected to the INT2 pin. > - > -Example: > - > -bma180@40 { > - compatible = "bosch,bma180"; > - reg = <0x40>; > - interrupt-parent = <&gpio6>; > - interrupts = <18 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma180.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma180.yaml > new file mode 100644 > index 000000000000..14e48290ffe3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma180.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bma180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMA023 / BMA150/ BMA180 / BMA25x / SMB380 triaxial accelerometers > + > +maintainers: > + - Oleksandr Kravchenko > + > +description: | > + https://media.digikey.com/pdf/Data%20Sheets/Bosch/BMA150.pdf > + http://omapworld.com/BMA180_111_1002839.pdf > + http://ae-bst.resource.bosch.com/media/products/dokumente/bma250/bst-bma250-ds002-05.pdf > + > +properties: > + compatible: > + enum: > + - bosch,bma023 > + - bosch,bma150 > + - bosch,bma180 > + - bosch,bma250 > + - bosch,bma254 > + - bosch,smb380 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > + vddio-supply: true > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + description: | > + Type should be either IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING. > + For the bma250 the first interrupt listed must be the one > + connected to the INT1 pin, the second (optional) interrupt > + listed must be the one connected to the INT2 pin. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + accel@40 { > + compatible = "bosch,bma180"; > + reg = <0x40>; > + interrupt-parent = <&gpio6>; > + interrupts = <18 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>; > + }; > + }; > +...