From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC19DC64E8A for ; Sat, 28 Nov 2020 22:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C869222C2 for ; Sat, 28 Nov 2020 22:21:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uGI2HUE7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388274AbgK1Vtd (ORCPT ); Sat, 28 Nov 2020 16:49:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:47532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730567AbgK1Sl4 (ORCPT ); Sat, 28 Nov 2020 13:41:56 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59D37246C1; Sat, 28 Nov 2020 16:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606580147; bh=DqS5YYy9W5SG1eb0ykyOMwA4cjtF5BIMVnfJ92mEadM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uGI2HUE7WASPx7pptdjVrB1P4ljFfuy3nQt0mLrMrCYziwPxVKPOPSlK6P9GhR3Zn f5ix6hGKne8K3M6j5kskWzRDZmJu7DwUE+/ArD7MgSU/jrZ2b8zowOxhlwfzomFybk mHluMu/pYLuMWrMf2K7PU7/GMTEHRtAtzn1pFdtg= Date: Sat, 28 Nov 2020 16:15:42 +0000 From: Jonathan Cameron To: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Cc: Jonathan Cameron Subject: Re: [PATCH 07/46] dt-bindings:iio:health:ti,afe4403: txt to yaml binding Message-ID: <20201128161542.5481ab9f@archlinux> In-Reply-To: <20201122173211.26f4a912@archlinux> References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-8-jic23@kernel.org> <20201122173211.26f4a912@archlinux> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 22 Nov 2020 17:32:11 +0000 Jonathan Cameron wrote: > On Sat, 31 Oct 2020 18:48:15 +0000 > Jonathan Cameron wrote: > > > From: Jonathan Cameron > > > > A few questions came up whilst converting this one. > > 1) What is actually required? > > - Checking Linux driver, interrupt is not, and the tx-supply could > > be supplied by a stub regulator as long as it's always on. > > As such I have reduced the required list to just compatible and reg. > > 2) What is the regulator called? > > - It's tx-supply in the binding doc, but the driver request tx_sup > > I've left this alone for now. Andrew could you confirm what is > > intended for this? > > Andrew's email seems to be bouncing so I've reached out to him via another > means. Will wait to see if that works before applying this or the next > patch given the questions. In order to move forwards with this I've put myself as maintainer and decided to send out a fix for the driver naming of that supply. Thanks, Jonathan > > Thanks, > > Jonathan > > > > > Signed-off-by: Jonathan Cameron > > Cc: Andrew F. Davis > > --- > > .../bindings/iio/health/afe4403.txt | 33 ------------ > > .../bindings/iio/health/ti,afe4403.yaml | 54 +++++++++++++++++++ > > 2 files changed, 54 insertions(+), 33 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/health/afe4403.txt b/Documentation/devicetree/bindings/iio/health/afe4403.txt > > deleted file mode 100644 > > index 8e412054d6d5..000000000000 > > --- a/Documentation/devicetree/bindings/iio/health/afe4403.txt > > +++ /dev/null > > @@ -1,33 +0,0 @@ > > -Texas Instruments AFE4403 Heart rate and Pulse Oximeter > > - > > -Required properties: > > - - compatible : Should be "ti,afe4403". > > - - reg : SPI chip select address of device. > > - - tx-supply : Regulator supply to transmitting LEDs. > > - - interrupts : The interrupt line the device ADC_RDY pin is > > - connected to. For details refer to, > > - ../../interrupt-controller/interrupts.txt. > > - > > -Optional properties: > > - - reset-gpios : GPIO used to reset the device. > > - For details refer to, ../../gpio/gpio.txt. > > - > > -For other required and optional properties of SPI slave nodes > > -please refer to ../../spi/spi-bus.txt. > > - > > -Example: > > - > > -&spi0 { > > - heart_mon@0 { > > - compatible = "ti,afe4403"; > > - reg = <0>; > > - spi-max-frequency = <10000000>; > > - > > - tx-supply = <&vbat>; > > - > > - interrupt-parent = <&gpio1>; > > - interrupts = <28 IRQ_TYPE_EDGE_RISING>; > > - > > - reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > > new file mode 100644 > > index 000000000000..5c86db65c033 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/health/ti,afe4403.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Texas Instruments AFE4403 Heart rate and Pulse Oximeter > > + > > +maintainers: > > + - Andrew F. Davis > > + > > +properties: > > + compatible: > > + const: ti,afe4403 > > + > > + reg: > > + maxItems: 1 > > + > > + tx-supply: > > + description: Supply to transmitting LEDs. > > + > > + interrupts: > > + maxItems: 1 > > + description: Connected to ADC_RDY pin. > > + > > + reset-gpios: true > > + > > + spi-max-frequency: true > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + #include > > + #include > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + heart_mon@0 { > > + compatible = "ti,afe4403"; > > + reg = <0>; > > + spi-max-frequency = <10000000>; > > + tx-supply = <&vbat>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <28 IRQ_TYPE_EDGE_RISING>; > > + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; > > + }; > > + }; > > +... >