From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A22EC83014 for ; Sat, 28 Nov 2020 22:21:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F066C2225A for ; Sat, 28 Nov 2020 22:21:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gZxBozCr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388408AbgK1Vti (ORCPT ); Sat, 28 Nov 2020 16:49:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:48966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732024AbgK1S53 (ORCPT ); Sat, 28 Nov 2020 13:57:29 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB58A246C3; Sat, 28 Nov 2020 16:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606580698; bh=gptWJ/cb79ddHX/fQgX47yWUFgbvauycDWkQSMwuDgU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gZxBozCrxAMmYTg/z60FIPfVZZwpodRJ36T/sG6QdIxCUzRrcr/0ZrYCEwzo/wruP qq7PNQCEhujK++Wg0gUi6G994svfQHiLDJ/wDsdXMYTQFOO2RsMMWGuWQUr4dnTcXd 8MB1VaA/ySCXMGLPchjhrf5oL3s8JP/B32Oza5LQ= Date: Sat, 28 Nov 2020 16:24:54 +0000 From: Jonathan Cameron To: linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Cc: Jonathan Cameron Subject: Re: [PATCH 08/46] dt-bindings:iio:health:ti,afe4404: txt to yaml conversion Message-ID: <20201128162454.1ce33824@archlinux> In-Reply-To: <20201031184854.745828-9-jic23@kernel.org> References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-9-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 31 Oct 2020 18:48:16 +0000 Jonathan Cameron wrote: > From: Jonathan Cameron > > This basically has same questions as for the afe4403. We could combine > the two bindings, but as the drivers are separate and it would be a little > fiddly due to different buses let's keep the separating. > To repeat questions from the ti,afe4403 binding. > > A few questions came up whilst converting this one. > 1) What is actually required? > - Checking Linux driver, interrupt is not, and the tx-supply could > be supplied by a stub regulator as long as it's always on. > As such I have reduced the required list to just compatible and reg. > 2) What is the regulator called? > - It's tx-supply in the binding doc, but the driver request tx_sup > I've left this alone for now. Andrew could you confirm what is > intended for this? > > Signed-off-by: Jonathan Cameron > Cc: Andrew F. Davis Applied. with the maintainer switched to me for now as Andrew's email is bouncing. Thanks, Jonathan > --- > .../bindings/iio/health/afe4404.txt | 29 ----------- > .../bindings/iio/health/ti,afe4404.yaml | 51 +++++++++++++++++++ > 2 files changed, 51 insertions(+), 29 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/health/afe4404.txt b/Documentation/devicetree/bindings/iio/health/afe4404.txt > deleted file mode 100644 > index 0b52830a0d9c..000000000000 > --- a/Documentation/devicetree/bindings/iio/health/afe4404.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -Texas Instruments AFE4404 Heart rate and Pulse Oximeter > - > -Required properties: > - - compatible : Should be "ti,afe4404". > - - reg : I2C address of the device. > - - tx-supply : Regulator supply to transmitting LEDs. > - - interrupts : The interrupt line the device ADC_RDY pin is > - connected to. For details refer to, > - ../interrupt-controller/interrupts.txt. > - > -Optional properties: > - - reset-gpios : GPIO used to reset the device. > - For details refer to, ../gpio/gpio.txt. > - > -Example: > - > -&i2c2 { > - heart_mon@58 { > - compatible = "ti,afe4404"; > - reg = <0x58>; > - > - tx-supply = <&vbat>; > - > - interrupt-parent = <&gpio1>; > - interrupts = <28 IRQ_TYPE_EDGE_RISING>; > - > - reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > new file mode 100644 > index 000000000000..187b99b22312 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments AFE4404 Heart rate and Pulse Oximeter > + > +maintainers: > + - Andrew F. Davis > + > +properties: > + compatible: > + const: ti,afe4403 > + > + reg: > + maxItems: 1 > + > + tx-supply: > + description: Supply to transmitting LEDs. > + > + interrupts: > + maxItems: 1 > + description: Connected to ADC_RDY pin. > + > + reset-gpios: true > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + heart_mon@58 { > + compatible = "ti,afe4404"; > + reg = <0x58>; > + tx-supply = <&vbat>; > + interrupt-parent = <&gpio1>; > + interrupts = <28 IRQ_TYPE_EDGE_RISING>; > + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; > + }; > + }; > +...