From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92FBC433FE for ; Mon, 7 Dec 2020 19:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DDC921D7F for ; Mon, 7 Dec 2020 19:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725822AbgLGTyp (ORCPT ); Mon, 7 Dec 2020 14:54:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:34250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgLGTyo (ORCPT ); Mon, 7 Dec 2020 14:54:44 -0500 Date: Mon, 7 Dec 2020 21:53:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607370844; bh=BdQC2xqiYbPynB6ee1sdspvA3uTspzSbKGlxef667To=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=kbxSe+Y/JdDEtvEzmtinEDS3lvUlkk8ZbniyyDKsnPBeNYiZjGeBQwY9I59c4NxFk v+6syZLGTWmP55ItOhK3KMVEHhOFnYu6vYJhz4XikpGFjJ6zFxqtrhizL8gMNy+cs9 7rZFF2ZlqVeRNSXiF+jMYZPEwQcy8uvGzhjWOgZZH+9Pco+xh2oaqSivE8USm+ygTo QGA1K5R+mybGUTwhITOTadiNOwZp8JhnmZakqCD6TznNb4+oIQvM1ozdjalRxapshX +VISJ1RQnvrPgSG/v+qE8DwS0ufYFF7OOfJd6iQn9LU9uErqg9Hfi7TnBskMmlkUpl PH2gy5ASiwbpA== From: Leon Romanovsky To: Saravana Kannan Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Ard Biesheuvel , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Tomi Valkeinen , Laurent Pinchart , Grygorii Strashko , Android Kernel Team , ACPI Devel Maling List , LKML , linux-efi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v2 07/17] driver core: Add fwnode_init() Message-ID: <20201207195357.GF693271@unreal> References: <20201121020232.908850-1-saravanak@google.com> <20201121020232.908850-8-saravanak@google.com> <20201206072621.GA687065@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 07, 2020 at 11:25:15AM -0800, Saravana Kannan wrote: > On Sat, Dec 5, 2020 at 11:26 PM Leon Romanovsky wrote: > > > > On Fri, Nov 20, 2020 at 06:02:22PM -0800, Saravana Kannan wrote: > > > There are multiple locations in the kernel where a struct fwnode_handle > > > is initialized. Add fwnode_init() so that we have one way of > > > initializing a fwnode_handle. > > > > > > Signed-off-by: Saravana Kannan > > > --- > > > drivers/acpi/property.c | 2 +- > > > drivers/acpi/scan.c | 2 +- > > > drivers/base/swnode.c | 2 +- > > > drivers/firmware/efi/efi-init.c | 8 ++++---- > > > include/linux/fwnode.h | 6 ++++++ > > > include/linux/of.h | 2 +- > > > kernel/irq/irqdomain.c | 2 +- > > > 7 files changed, 15 insertions(+), 9 deletions(-) > > > > In this series, I didn't find any extension of fwnode_init() to be it more > > than simple assignment. This change looks to me like unnecessary churn and > > obfuscation rather than improvement. > > > > "...ops = &...;" is pretty standard in the kernel to initialize ops > > structures. > > Subsequent patches make fwnode_init() do more stuff. But not in this series, right? Thanks > > -Saravana