From: Jonathan Cameron <jic23@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 2/3] Documentation/ABI/testing: Add documentation for AD5766 new ABI
Date: Sat, 9 Jan 2021 19:08:02 +0000 [thread overview]
Message-ID: <20210109190802.4c4fcbc2@archlinux> (raw)
In-Reply-To: <20210108183739.27634-2-cristian.pop@analog.com>
On Fri, 8 Jan 2021 20:37:38 +0200
Cristian Pop <cristian.pop@analog.com> wrote:
> New interface is proposed for dither functionality. This future allows
> composing an external signals to the selected output channel.
> The dither signal can be turned on/off, scaled, inverted, or it can be
> selected from different sources.
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
Hi Cristian,
One trivial inline to fix if you need to respin. Otherwise I can tidy up whilst
applying.
Jonathan
> ---
> Changelog v5:
> - Rename property to: "in_voltageY_dither_enable"
> - Change scale values to: "1 0.75 0.5 0.25"
> - Specify KernelVersion
> .../ABI/testing/sysfs-bus-iio-dac-ad5766 | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac-ad5766
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-dac-ad5766 b/Documentation/ABI/testing/sysfs-bus-iio-dac-ad5766
> new file mode 100644
> index 000000000000..6e5e383b2c53
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-dac-ad5766
> @@ -0,0 +1,31 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_dither_ennable
Typo, enable but I can fix that whilst applying if there is nothing else.
Jonathan
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Dither enable. Write 1 to enable dither or 0 to disable it.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_dither_invert
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Inverts the dither applied to the selected DAC channel. Dither is not
> + inverted by default. Write "1" to invert dither.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_dither_scale_available
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Returns possible scalings available for the current channel.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_dither_scale
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Scales the dither before it is applied to the selected channel.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_dither_source
> +KernelVersion: 5.12
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Selects dither source applied to the selected channel. Write "0" to
> + select N0 source, write "1" to select N1 source.
next prev parent reply other threads:[~2021-01-09 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 18:37 [PATCH v5 1/3] dt-bindings: iio: dac: AD5766 yaml documentation Cristian Pop
2021-01-08 18:37 ` [PATCH v5 2/3] Documentation/ABI/testing: Add documentation for AD5766 new ABI Cristian Pop
2021-01-09 19:08 ` Jonathan Cameron [this message]
2021-01-08 18:37 ` [PATCH v5 3/3] iio: dac: ad5766: add driver support for AD5766 Cristian Pop
2021-01-09 19:21 ` Jonathan Cameron
2021-01-11 19:54 ` [PATCH v5 1/3] dt-bindings: iio: dac: AD5766 yaml documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109190802.4c4fcbc2@archlinux \
--to=jic23@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).