From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Simon Budig <simon.budig@kernelconcepts.de>,
Ondrej Jirman <megous@megous.com>
Subject: Re: [PATCH 2/2] Input: edt-ft5x06 - add support for iovcc-supply
Date: Mon, 11 Jan 2021 12:22:36 +0200 [thread overview]
Message-ID: <20210111102236.GT4077@smile.fi.intel.com> (raw)
In-Reply-To: <X/wZqiRbx6nmrj0e@gerhold.net>
On Mon, Jan 11, 2021 at 10:26:25AM +0100, Stephan Gerhold wrote:
> On Mon, Jan 11, 2021 at 09:36:12AM +0100, Marco Felsch wrote:
> > On 21-01-08 20:23, Stephan Gerhold wrote:
...
> > > + if (error)
> > > + return dev_err_probe(&client->dev, error,
> > > + "failed to request regulators\n");
> >
> > It would be nice to have a patch in front of this one which handles the
> > support for dev_err_probe().
> >
>
> OK, I can send a v2 with the dev_err_probe() change separated into an
> extra patch.
AFAIR Dmitry has strong opinion against dev_err_probe(). But I might be
mistaken.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-11 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 19:23 [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: add iovcc-supply Stephan Gerhold
2021-01-08 19:23 ` [PATCH 2/2] Input: edt-ft5x06 - add support for iovcc-supply Stephan Gerhold
2021-01-11 8:36 ` Marco Felsch
2021-01-11 9:26 ` Stephan Gerhold
2021-01-11 9:45 ` Marco Felsch
2021-01-11 10:10 ` Stephan Gerhold
2021-01-11 15:46 ` Stephan Gerhold
2021-01-11 10:22 ` Andy Shevchenko [this message]
2021-01-11 10:43 ` Stephan Gerhold
2021-01-13 15:25 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: add iovcc-supply Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111102236.GT4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=simon.budig@kernelconcepts.de \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).