* [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
@ 2021-01-12 13:17 Rafał Miłecki
2021-01-13 4:48 ` Florian Fainelli
2021-01-13 11:09 ` [PATCH V2] " Rafał Miłecki
0 siblings, 2 replies; 7+ messages in thread
From: Rafał Miłecki @ 2021-01-12 13:17 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the
internal MDIO.
CPU port and Ethernet interface remain to be documented.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++-
2 files changed, 135 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index 13c6b86eef21..51305e96fbd6 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -44,6 +44,57 @@ brightness {
};
};
+&ports {
+ port@0 {
+ label = "lan2";
+ };
+
+ port@1 {
+ label = "lan1";
+ };
+
+ port@2 {
+ label = "lan6";
+ };
+
+ port@3 {
+ label = "lan5";
+ };
+
+ /* External BCM53134S switch */
+ port@7 {
+ label = "sw";
+ reg = <7>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+};
+
+&mdio {
+ /* lan8 */
+ phy@0 {
+ reg = <0>;
+ };
+
+ /* lan7 */
+ phy@1 {
+ reg = <1>;
+ };
+
+ /* lan4 */
+ phy@2 {
+ reg = <2>;
+ };
+
+ /* lan3 */
+ phy@3 {
+ reg = <3>;
+ };
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index b5b772a9a51b..0b44f32fdef1 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@ soc {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x00 0x00 0x80000000 0x10000>;
+ ranges = <0x00 0x00 0x80000000 0xd0000>;
usb@c300 {
compatible = "generic-ehci";
@@ -130,6 +130,89 @@ usb@d000 {
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
+
+ switch@80000 {
+ compatible = "simple-mfd";
+ #size-cells = <1>;
+ #address-cells = <1>;
+ ranges = <0 0x80000 0x50000>;
+
+ switch@0 {
+ compatible = "brcm,bcm4908-switch";
+ reg = <0x0 0x40000>,
+ <0x40000 0x110>,
+ <0x40340 0x30>,
+ <0x40380 0x30>,
+ <0x40600 0x34>,
+ <0x40800 0x208>;
+ reg-names = "core", "reg", "intrl2_0",
+ "intrl2_1", "fcb", "acb";
+ interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
+ brcm,num-gphy = <5>;
+ brcm,num-rgmii-ports = <2>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ phy-mode = "internal";
+ phy-handle = <&phy8>;
+ };
+
+ port@1 {
+ reg = <1>;
+ phy-mode = "internal";
+ phy-handle = <&phy9>;
+ };
+
+ port@2 {
+ reg = <2>;
+ phy-mode = "internal";
+ phy-handle = <&phy10>;
+ };
+
+ port@3 {
+ reg = <3>;
+ phy-mode = "internal";
+ phy-handle = <&phy11>;
+ };
+ };
+ };
+
+ mdio: mdio@405c0 {
+ compatible = "brcm,unimac-mdio";
+ reg = <0x405c0 0x8>;
+ reg-names = "mdio";
+ #size-cells = <1>;
+ #address-cells = <0>;
+
+ phy8: phy@8 {
+ reg = <8>;
+ };
+
+ phy9: phy@9 {
+ reg = <9>;
+ };
+
+ phy10: phy@a {
+ reg = <10>;
+ };
+
+ phy11: phy@b {
+ reg = <11>;
+ };
+
+ phy12: phy@c {
+ reg = <12>;
+ };
+ };
+ };
};
bus@ff800000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-12 13:17 [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch Rafał Miłecki
@ 2021-01-13 4:48 ` Florian Fainelli
2021-01-13 11:09 ` [PATCH V2] " Rafał Miłecki
1 sibling, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2021-01-13 4:48 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
On 1/12/2021 5:17 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
> connected to the internal PHYs. Remaining ports depend on device setup.
>
> Asus GT-AC5300 has an extra switch with its PHYs accessible using the
> internal MDIO.
>
> CPU port and Ethernet interface remain to be documented.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++
> .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++-
> 2 files changed, 135 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> index 13c6b86eef21..51305e96fbd6 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> @@ -44,6 +44,57 @@ brightness {
> };
> };
>
> +&ports {
> + port@0 {
> + label = "lan2";
> + };
> +
> + port@1 {
> + label = "lan1";
> + };
> +
> + port@2 {
> + label = "lan6";
> + };
> +
> + port@3 {
> + label = "lan5";
> + };
> +
> + /* External BCM53134S switch */
> + port@7 {
> + label = "sw";
> + reg = <7>;
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +};
> +
> +&mdio {
> + /* lan8 */
> + phy@0 {
> + reg = <0>;
> + };
> +
> + /* lan7 */
> + phy@1 {
> + reg = <1>;
> + };
> +
> + /* lan4 */
> + phy@2 {
> + reg = <2>;
> + };
> +
> + /* lan3 */
> + phy@3 {
> + reg = <3>;
> + };
> +};
> +
> &nandcs {
> nand-ecc-strength = <4>;
> nand-ecc-step-size = <512>;
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> index b5b772a9a51b..0b44f32fdef1 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> @@ -108,7 +108,7 @@ soc {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x00 0x00 0x80000000 0x10000>;
> + ranges = <0x00 0x00 0x80000000 0xd0000>;
>
> usb@c300 {
> compatible = "generic-ehci";
> @@ -130,6 +130,89 @@ usb@d000 {
> interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> +
> + switch@80000 {
> + compatible = "simple-mfd";
Should not this be simple-bus instead? That is what I used in the 7445
and 7278 Device Trees provided by the bootloader, and also what was in
the sf2 example binding.
> + #size-cells = <1>;
> + #address-cells = <1>;
> + ranges = <0 0x80000 0x50000>;
> +
> + switch@0 {
> + compatible = "brcm,bcm4908-switch";
> + reg = <0x0 0x40000>,
> + <0x40000 0x110>,
> + <0x40340 0x30>,
> + <0x40380 0x30>,
> + <0x40600 0x34>,
> + <0x40800 0x208>;
> + reg-names = "core", "reg", "intrl2_0",
> + "intrl2_1", "fcb", "acb";
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> + brcm,num-gphy = <5>;
> + brcm,num-rgmii-ports = <2>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ports: ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + phy-mode = "internal";
> + phy-handle = <&phy8>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + phy-mode = "internal";
> + phy-handle = <&phy9>;
> + };
> +
> + port@2 {
> + reg = <2>;
> + phy-mode = "internal";
> + phy-handle = <&phy10>;
> + };
> +
> + port@3 {
> + reg = <3>;
> + phy-mode = "internal";
> + phy-handle = <&phy11>;
> + };
> + };
> + };
> +
> + mdio: mdio@405c0 {
> + compatible = "brcm,unimac-mdio";
> + reg = <0x405c0 0x8>;
> + reg-names = "mdio";
> + #size-cells = <1>;
> + #address-cells = <0>;
> +
> + phy8: phy@8 {
> + reg = <8>;
> + };
> +
> + phy9: phy@9 {
> + reg = <9>;
> + };
> +
> + phy10: phy@a {
> + reg = <10>;
> + };
> +
> + phy11: phy@b {
> + reg = <11>;
> + };
> +
> + phy12: phy@c {
> + reg = <12>;
> + };
> + };
> + };
> };
>
> bus@ff800000 {
>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V2] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-12 13:17 [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch Rafał Miłecki
2021-01-13 4:48 ` Florian Fainelli
@ 2021-01-13 11:09 ` Rafał Miłecki
2021-01-13 11:14 ` [PATCH V2x] " Rafał Miłecki
2021-01-20 18:58 ` [PATCH V2] " Florian Fainelli
1 sibling, 2 replies; 7+ messages in thread
From: Rafał Miłecki @ 2021-01-13 11:09 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the
internal MDIO.
CPU port and Ethernet interface remain to be documented.
---
V2: Use simple-bus
---
.../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++-
2 files changed, 135 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index 13c6b86eef21..51305e96fbd6 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -44,6 +44,57 @@ brightness {
};
};
+&ports {
+ port@0 {
+ label = "lan2";
+ };
+
+ port@1 {
+ label = "lan1";
+ };
+
+ port@2 {
+ label = "lan6";
+ };
+
+ port@3 {
+ label = "lan5";
+ };
+
+ /* External BCM53134S switch */
+ port@7 {
+ label = "sw";
+ reg = <7>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+};
+
+&mdio {
+ /* lan8 */
+ phy@0 {
+ reg = <0>;
+ };
+
+ /* lan7 */
+ phy@1 {
+ reg = <1>;
+ };
+
+ /* lan4 */
+ phy@2 {
+ reg = <2>;
+ };
+
+ /* lan3 */
+ phy@3 {
+ reg = <3>;
+ };
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index b5b772a9a51b..d30dd2042786 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@ soc {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x00 0x00 0x80000000 0x10000>;
+ ranges = <0x00 0x00 0x80000000 0xd0000>;
usb@c300 {
compatible = "generic-ehci";
@@ -130,6 +130,89 @@ usb@d000 {
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
+
+ switch@80000 {
+ compatible = "simple-bus";
+ #size-cells = <1>;
+ #address-cells = <1>;
+ ranges = <0 0x80000 0x50000>;
+
+ switch@0 {
+ compatible = "brcm,bcm4908-switch";
+ reg = <0x0 0x40000>,
+ <0x40000 0x110>,
+ <0x40340 0x30>,
+ <0x40380 0x30>,
+ <0x40600 0x34>,
+ <0x40800 0x208>;
+ reg-names = "core", "reg", "intrl2_0",
+ "intrl2_1", "fcb", "acb";
+ interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
+ brcm,num-gphy = <5>;
+ brcm,num-rgmii-ports = <2>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ phy-mode = "internal";
+ phy-handle = <&phy8>;
+ };
+
+ port@1 {
+ reg = <1>;
+ phy-mode = "internal";
+ phy-handle = <&phy9>;
+ };
+
+ port@2 {
+ reg = <2>;
+ phy-mode = "internal";
+ phy-handle = <&phy10>;
+ };
+
+ port@3 {
+ reg = <3>;
+ phy-mode = "internal";
+ phy-handle = <&phy11>;
+ };
+ };
+ };
+
+ mdio: mdio@405c0 {
+ compatible = "brcm,unimac-mdio";
+ reg = <0x405c0 0x8>;
+ reg-names = "mdio";
+ #size-cells = <1>;
+ #address-cells = <0>;
+
+ phy8: phy@8 {
+ reg = <8>;
+ };
+
+ phy9: phy@9 {
+ reg = <9>;
+ };
+
+ phy10: phy@a {
+ reg = <10>;
+ };
+
+ phy11: phy@b {
+ reg = <11>;
+ };
+
+ phy12: phy@c {
+ reg = <12>;
+ };
+ };
+ };
};
bus@ff800000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2x] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-13 11:09 ` [PATCH V2] " Rafał Miłecki
@ 2021-01-13 11:14 ` Rafał Miłecki
2021-01-20 18:58 ` [PATCH V2] " Florian Fainelli
1 sibling, 0 replies; 7+ messages in thread
From: Rafał Miłecki @ 2021-01-13 11:14 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the
internal MDIO.
CPU port and Ethernet interface remain to be documented.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Resending V2 with Signed-off-by included
V2: Use simple-bus
---
.../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++-
2 files changed, 135 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index 13c6b86eef21..51305e96fbd6 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -44,6 +44,57 @@ brightness {
};
};
+&ports {
+ port@0 {
+ label = "lan2";
+ };
+
+ port@1 {
+ label = "lan1";
+ };
+
+ port@2 {
+ label = "lan6";
+ };
+
+ port@3 {
+ label = "lan5";
+ };
+
+ /* External BCM53134S switch */
+ port@7 {
+ label = "sw";
+ reg = <7>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+};
+
+&mdio {
+ /* lan8 */
+ phy@0 {
+ reg = <0>;
+ };
+
+ /* lan7 */
+ phy@1 {
+ reg = <1>;
+ };
+
+ /* lan4 */
+ phy@2 {
+ reg = <2>;
+ };
+
+ /* lan3 */
+ phy@3 {
+ reg = <3>;
+ };
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index b5b772a9a51b..d30dd2042786 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@ soc {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x00 0x00 0x80000000 0x10000>;
+ ranges = <0x00 0x00 0x80000000 0xd0000>;
usb@c300 {
compatible = "generic-ehci";
@@ -130,6 +130,89 @@ usb@d000 {
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
+
+ switch@80000 {
+ compatible = "simple-bus";
+ #size-cells = <1>;
+ #address-cells = <1>;
+ ranges = <0 0x80000 0x50000>;
+
+ switch@0 {
+ compatible = "brcm,bcm4908-switch";
+ reg = <0x0 0x40000>,
+ <0x40000 0x110>,
+ <0x40340 0x30>,
+ <0x40380 0x30>,
+ <0x40600 0x34>,
+ <0x40800 0x208>;
+ reg-names = "core", "reg", "intrl2_0",
+ "intrl2_1", "fcb", "acb";
+ interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
+ brcm,num-gphy = <5>;
+ brcm,num-rgmii-ports = <2>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ phy-mode = "internal";
+ phy-handle = <&phy8>;
+ };
+
+ port@1 {
+ reg = <1>;
+ phy-mode = "internal";
+ phy-handle = <&phy9>;
+ };
+
+ port@2 {
+ reg = <2>;
+ phy-mode = "internal";
+ phy-handle = <&phy10>;
+ };
+
+ port@3 {
+ reg = <3>;
+ phy-mode = "internal";
+ phy-handle = <&phy11>;
+ };
+ };
+ };
+
+ mdio: mdio@405c0 {
+ compatible = "brcm,unimac-mdio";
+ reg = <0x405c0 0x8>;
+ reg-names = "mdio";
+ #size-cells = <1>;
+ #address-cells = <0>;
+
+ phy8: phy@8 {
+ reg = <8>;
+ };
+
+ phy9: phy@9 {
+ reg = <9>;
+ };
+
+ phy10: phy@a {
+ reg = <10>;
+ };
+
+ phy11: phy@b {
+ reg = <11>;
+ };
+
+ phy12: phy@c {
+ reg = <12>;
+ };
+ };
+ };
};
bus@ff800000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-13 11:09 ` [PATCH V2] " Rafał Miłecki
2021-01-13 11:14 ` [PATCH V2x] " Rafał Miłecki
@ 2021-01-20 18:58 ` Florian Fainelli
2021-01-20 19:07 ` Rafał Miłecki
1 sibling, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2021-01-20 18:58 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Wed, 13 Jan 2021 12:09:46 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
> connected to the internal PHYs. Remaining ports depend on device setup.
>
> Asus GT-AC5300 has an extra switch with its PHYs accessible using the
> internal MDIO.
>
> CPU port and Ethernet interface remain to be documented.
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-20 18:58 ` [PATCH V2] " Florian Fainelli
@ 2021-01-20 19:07 ` Rafał Miłecki
2021-01-20 19:09 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Rafał Miłecki @ 2021-01-20 19:07 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rafał Miłecki, Rob Herring,
linux-arm-kernel, devicetree
On 2021-01-20 19:58, Florian Fainelli wrote:
> On Wed, 13 Jan 2021 12:09:46 +0100, Rafał Miłecki <zajec5@gmail.com>
> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
>> connected to the internal PHYs. Remaining ports depend on device
>> setup.
>>
>> Asus GT-AC5300 has an extra switch with its PHYs accessible using the
>> internal MDIO.
>>
>> CPU port and Ethernet interface remain to be documented.
>> ---
>
> Applied to devicetree-arm64/next, thanks!
You may need to pick a patch sent as
[PATCH V2x] arm64: dts: broadcom: bcm4908: describe internal switch
instead.
V2x contains Signed-off-by which I missed in the V2.
Sorry for the inconvenience!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] arm64: dts: broadcom: bcm4908: describe internal switch
2021-01-20 19:07 ` Rafał Miłecki
@ 2021-01-20 19:09 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2021-01-20 19:09 UTC (permalink / raw)
To: Rafał Miłecki
Cc: bcm-kernel-feedback-list, Rafał Miłecki, Rob Herring,
linux-arm-kernel, devicetree
On 1/20/2021 11:07 AM, Rafał Miłecki wrote:
> On 2021-01-20 19:58, Florian Fainelli wrote:
>> On Wed, 13 Jan 2021 12:09:46 +0100, Rafał Miłecki <zajec5@gmail.com>
>> wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always
>>> connected to the internal PHYs. Remaining ports depend on device setup.
>>>
>>> Asus GT-AC5300 has an extra switch with its PHYs accessible using the
>>> internal MDIO.
>>>
>>> CPU port and Ethernet interface remain to be documented.
>>> ---
>>
>> Applied to devicetree-arm64/next, thanks!
>
> You may need to pick a patch sent as
> [PATCH V2x] arm64: dts: broadcom: bcm4908: describe internal switch
> instead.
>
> V2x contains Signed-off-by which I missed in the V2.
>
> Sorry for the inconvenience!
Yes I realized that but applied V2x and pushed it out thanks!
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-20 19:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 13:17 [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch Rafał Miłecki
2021-01-13 4:48 ` Florian Fainelli
2021-01-13 11:09 ` [PATCH V2] " Rafał Miłecki
2021-01-13 11:14 ` [PATCH V2x] " Rafał Miłecki
2021-01-20 18:58 ` [PATCH V2] " Florian Fainelli
2021-01-20 19:07 ` Rafał Miłecki
2021-01-20 19:09 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).