Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V
@ 2021-01-24 21:03 Uwe Kleine-König
  2021-01-24 21:03 ` [PATCH 2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l Uwe Kleine-König
  2021-01-25 23:56 ` [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2021-01-24 21:03 UTC (permalink / raw)
  To: Rob Herring, Heiko Stuebner; +Cc: devicetree, linux-rockchip, Aditya Prayoga

While comparing the vendor dts with the one added in v5.11-rc1 I noticed
that the vendor dts specified 3.3 V which matches the SDIO specification.

So fix the sdio regulator to provide (up to) 3.3 V.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 2a561be724b2..d6446c32b91e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -251,11 +251,11 @@ vcc_sdio_s0: LDO_REG4 {
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3000000>;
+				regulator-max-microvolt = <3300000>;
 
 				regulator-state-mem {
 					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3000000>;
+					regulator-suspend-microvolt = <3300000>;
 				};
 			};
 

base-commit: 19c329f6808995b142b3966301f217c831e7cf31
-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l
  2021-01-24 21:03 [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Uwe Kleine-König
@ 2021-01-24 21:03 ` Uwe Kleine-König
  2021-01-25 23:56 ` [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2021-01-24 21:03 UTC (permalink / raw)
  To: Rob Herring, Heiko Stuebner; +Cc: devicetree, linux-rockchip, Aditya Prayoga

According to the schematic there is an external pull up, so there is no
need to enable the internal one additionally. Using no pull up matches
the vendor device tree.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index d6446c32b91e..1e880a0a3f69 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -331,7 +331,7 @@ sys_red_led_on: sys-red-led-on {
 
 	pmic {
 		pmic_int_l: pmic-int-l {
-			rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
+			rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V
  2021-01-24 21:03 [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Uwe Kleine-König
  2021-01-24 21:03 ` [PATCH 2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l Uwe Kleine-König
@ 2021-01-25 23:56 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:56 UTC (permalink / raw)
  To: Uwe Kleine-König, Rob Herring
  Cc: Heiko Stuebner, Aditya Prayoga, linux-rockchip, devicetree

On Sun, 24 Jan 2021 22:03:27 +0100, Uwe Kleine-König wrote:
> While comparing the vendor dts with the one added in v5.11-rc1 I noticed
> that the vendor dts specified 3.3 V which matches the SDIO specification.
> 
> So fix the sdio regulator to provide (up to) 3.3 V.

Applied, thanks!

[1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V
      commit: d134ac731feed91a81b447e0e63c1c35523fc574
[2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l
      commit: 19de5156d0029ccdf0153cee35fb8356b56ba9c6

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-24 21:03 [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Uwe Kleine-König
2021-01-24 21:03 ` [PATCH 2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l Uwe Kleine-König
2021-01-25 23:56 ` [PATCH 1/2] arm64: dts: rockchip: Increase maximal SDIO voltage to 3.3 V Heiko Stuebner

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git