From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Luca Ceresoli <luca@lucaceresoli.net>,
Adam Ford <aford173@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
Date: Mon, 25 Jan 2021 15:24:42 -0600 [thread overview]
Message-ID: <20210125212442.GA1019390@robh.at.kernel.org> (raw)
In-Reply-To: <CAMuHMdWO5Uv22q8TuO4MQ_gv4LLT6UDCm0TrDtWe6DL=bbFKWw@mail.gmail.com>
On Wed, Jan 20, 2021 at 05:29:54PM +0100, Geert Uytterhoeven wrote:
> Hi Luca,
>
> On Wed, Jan 20, 2021 at 5:08 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
> > On 14/01/21 13:56, Geert Uytterhoeven wrote:
> > > - Add missing reference for "idt,voltage-microvolt",
> > > - Add missing "additionalProperties: false" for subnodes, to catch
> > > typos in properties,
> > > - Fix property names in example.
> > >
> > > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > v2:
> > > - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> > > ('clk: vc5: Use "idt,voltage-microvolt" instead of
> > > "idt,voltage-microvolts"'),
> > > - Drop reference to clock.yaml, which is already applied
> > > unconditionally,
> > > - Drop removal of allOf around if condition, as it is unnecessary
> > > churn.
> > > ---
> > > .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 ++++++---
> > > 1 file changed, 6 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > index 2ac1131fd9222a86..70239f992d714ae0 100644
> > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > @@ -75,12 +75,15 @@ patternProperties:
> > > maximum: 6
> > > idt,voltage-microvolt:
> > > description: The output drive voltage.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> >
> > "Vendor specific properties having a standard unit suffix don't need a
> > type." -- Documentation/devicetree/bindings/example-schema.yaml
>
> Thanks, will fix in v3!
>
> Rob: would this apply to idt,slew-percent, too?
> I.e. should -percent be added to dt-schema/schemas/property-units.yaml?
Yes.
Rob
prev parent reply other threads:[~2021-01-25 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 12:56 [PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
2021-01-20 16:08 ` Luca Ceresoli
2021-01-20 16:29 ` Geert Uytterhoeven
2021-01-25 21:24 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125212442.GA1019390@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).