From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: reserved-memory: Add Owl SoC serial number binding
Date: Thu, 1 Apr 2021 20:40:01 +0300 [thread overview]
Message-ID: <20210401174001.GA2016477@BV030612LT> (raw)
In-Reply-To: <20210401170704.GA610119@robh.at.kernel.org>
On Thu, Apr 01, 2021 at 12:07:04PM -0500, Rob Herring wrote:
> On Tue, Mar 30, 2021 at 04:48:16PM +0300, Cristian Ciocaltea wrote:
> > Add devicetree binding for the Actions Semi Owl SoC serial number
> > reserved-memory range.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> > .../actions,owl-soc-serial.yaml | 53 +++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml b/Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml
> > new file mode 100644
> > index 000000000000..41b71f47ee6c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reserved-memory/actions,owl-soc-serial.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reserved-memory/actions,owl-soc-serial.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Actions Semi Owl reserved-memory for SoC serial number
> > +
> > +maintainers:
> > + - Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > +
> > +description: |
> > + Provide access to the memory region where the two parts of the Actions
> > + Semi Owl SoC serial number (low & high) can be read from. This information
> > + is provided by the bootloader, hence expose it under /reserved-memory node.
> > +
> > + Please refer to reserved-memory.txt in this directory for common binding
> > + part and usage.
> > +
> > + This is currently supported only on the S500 SoC variant.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: actions,owl-soc-serial
> > + - items:
> > + - enum:
> > + - actions,s500-soc-serial
> > + - const: actions,owl-soc-serial
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > + - |
> > + reserved-memory {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + soc_serial: soc-serial@800 {
> > + compatible = "actions,s500-soc-serial", "actions,owl-soc-serial";
> > + reg = <0x800 0x8>;
>
> You end up wasting a whole page of memory for 8 bytes. It may be better
> to copy this to a DT property ('serial-number' is already a defined root
> property).
Actually there is more information provided by the vendor bootloader
in this memory page, so we might use it once we are able to decode it.
For the moment I could only identify the serial number.
Thanks,
Cristi
> Rob
next prev parent reply other threads:[~2021-04-01 18:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 13:48 [PATCH v2 0/6] Add support for Actions Semi Owl socinfo Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 1/6] dt-bindings: reserved-memory: Add Owl SoC serial number binding Cristian Ciocaltea
2021-04-01 17:07 ` Rob Herring
2021-04-01 17:40 ` Cristian Ciocaltea [this message]
2021-04-02 18:06 ` Manivannan Sadhasivam
2021-04-02 19:44 ` Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 2/6] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Cristian Ciocaltea
2021-04-01 17:08 ` Rob Herring
2021-04-01 17:57 ` Cristian Ciocaltea
2021-04-02 18:04 ` Manivannan Sadhasivam
2021-04-02 19:25 ` Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 3/6] soc: actions: Add Actions Semi Owl socinfo driver Cristian Ciocaltea
2021-04-02 18:16 ` Manivannan Sadhasivam
2021-04-02 19:36 ` Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 4/6] arm: dts: owl-s500: Add reserved-memory range for Owl SoC serial number Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 5/6] arm: dts: owl-s500: Add socinfo support Cristian Ciocaltea
2021-03-30 13:48 ` [PATCH v2 6/6] MAINTAINERS: Add entries for Owl reserved-memory and socinfo bindings Cristian Ciocaltea
2021-04-01 5:24 ` [PATCH v2 0/6] Add support for Actions Semi Owl socinfo Manivannan Sadhasivam
2021-04-01 9:40 ` Cristian Ciocaltea
2021-04-01 10:27 ` Manivannan Sadhasivam
2021-04-01 10:49 ` Andreas Färber
2021-04-01 10:58 ` Cristian Ciocaltea
2021-04-01 11:07 ` Manivannan Sadhasivam
2021-04-01 13:19 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401174001.GA2016477@BV030612LT \
--to=cristian.ciocaltea@gmail.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).