From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Zhang Rui" <rui.zhang@intel.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: thermal: brcm,ns-thermal: convert to the json-schema
Date: Tue, 20 Apr 2021 15:08:39 -0500 [thread overview]
Message-ID: <20210420200839.GA3724916@robh.at.kernel.org> (raw)
In-Reply-To: <20210415111655.4273-1-zajec5@gmail.com>
On Thu, Apr 15, 2021 at 01:16:55PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This helps validating DTS files.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/thermal/brcm,ns-thermal.txt | 37 ------------
> .../bindings/thermal/brcm,ns-thermal.yaml | 59 +++++++++++++++++++
> 2 files changed, 59 insertions(+), 37 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
> deleted file mode 100644
> index 68e047170039..000000000000
> --- a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -* Broadcom Northstar Thermal
> -
> -This binding describes thermal sensor that is part of Northstar's DMU (Device
> -Management Unit).
> -
> -Required properties:
> -- compatible : Must be "brcm,ns-thermal"
> -- reg : iomem address range of PVTMON registers
> -- #thermal-sensor-cells : Should be <0>
> -
> -Example:
> -
> -thermal: thermal@1800c2c0 {
> - compatible = "brcm,ns-thermal";
> - reg = <0x1800c2c0 0x10>;
> - #thermal-sensor-cells = <0>;
> -};
> -
> -thermal-zones {
> - cpu_thermal: cpu-thermal {
> - polling-delay-passive = <0>;
> - polling-delay = <1000>;
> - coefficients = <(-556) 418000>;
> - thermal-sensors = <&thermal>;
> -
> - trips {
> - cpu-crit {
> - temperature = <125000>;
> - hysteresis = <0>;
> - type = "critical";
> - };
> - };
> -
> - cooling-maps {
> - };
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
> new file mode 100644
> index 000000000000..50143e2f6bcb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/brcm,ns-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Northstar Thermal
> +
> +maintainers:
> + - Rafał Miłecki <rafal@milecki.pl>
> +
> +description:
> + Thermal sensor that is part of Northstar's DMU (Device Management Unit).
> +
> +allOf:
> + - $ref: thermal-sensor.yaml#
> +
> +properties:
> + compatible:
> + const: brcm,ns-thermal
> +
> + reg:
> + description: PVTMON registers range
How many?
> +
> + "#thermal-sensor-cells":
> + const: 0
> +
> +unevaluatedProperties: false
> +
> +required:
> + - reg
> +
> +examples:
> + - |
> + thermal: thermal@1800c2c0 {
> + compatible = "brcm,ns-thermal";
> + reg = <0x1800c2c0 0x10>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + thermal-zones {
> + cpu-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <1000>;
> + coefficients = <(-556) 418000>;
> + thermal-sensors = <&thermal>;
> +
> + trips {
> + cpu-crit {
> + temperature = <125000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + };
> + };
> + };
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-04-20 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 11:16 [PATCH] dt-bindings: thermal: brcm,ns-thermal: convert to the json-schema Rafał Miłecki
2021-04-20 20:08 ` Rob Herring [this message]
2021-04-20 21:01 ` [PATCH V2] " Rafał Miłecki
2021-04-21 17:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420200839.GA3724916@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=rui.zhang@intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).