From: Nishanth Menon <nm@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tero Kristo <kristo@kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] dt-bindings: arm: keystone: Convert ti,sci to json schema
Date: Thu, 22 Apr 2021 09:17:44 -0500 [thread overview]
Message-ID: <20210422141744.2imrochbzzt26wx4@slush> (raw)
In-Reply-To: <20210421224041.GA1740292@robh.at.kernel.org>
On 17:40-20210421, Rob Herring wrote:
[..]
> > +allOf:
> > + - $ref: /schemas/mbox/mbox-consumer.yaml#
>
> Drop.
>
OK.
> > + reg-names:
> > + description: |
> > + Specifies the debug messages memory mapped region that is optionally
> > + made available from TI-SCI controller.
> > + - const: debug_messages
>
> Drop the '-' and fix the indent so it's an actual schema.
OK.
[..]
> > +patternProperties:
> > + # All other properties should be a power, clock or reset controller
> > + "^(power-controller|clock-controller|reset-controller)$":
> > + type: object
> > + oneOf:
> > + - $ref: /schemas/soc/ti/sci-pm-domain.yaml#
> > + - $ref: /schemas/clock/ti,sci-clk.yaml#
> > + - $ref: /schemas/reset/ti,sci-reset.yaml#
>
> I'd prefer you separate these with a property for each node.
Hmm... I am not sure I completely understand your comment here.
I assume we dont want to duplicate each of those node yamls, so,
did you mean something like:
ti,sci-clk as a bool property in the tisci node and if present, then
expect the node ti,sci-clk node?
Can you give me a hint of similar yaml usage elsewhere that I can refer
to?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-04-22 14:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 6:37 [PATCH 0/4] dt-bindings: soc/arm: Convert pending ti,sci* bindings to json format Nishanth Menon
2021-04-16 6:37 ` [PATCH 1/4] dt-bindings: reset: Convert ti,sci-reset to json schema Nishanth Menon
2021-04-21 22:32 ` Rob Herring
2021-04-16 6:37 ` [PATCH 2/4] dt-bindings: clock: Convert ti,sci-clk " Nishanth Menon
2021-04-16 23:55 ` Stephen Boyd
2021-04-17 12:51 ` Nishanth Menon
2021-04-19 13:35 ` Nishanth Menon
2021-04-21 22:31 ` Rob Herring
2021-04-22 14:09 ` Nishanth Menon
2021-04-16 6:37 ` [PATCH 3/4] dt-bindings: soc: ti: Convert ti,sci-pm-domain " Nishanth Menon
2021-04-21 22:36 ` [PATCH 3/4] dt-bindings: soc: ti: Convert ti, sci-pm-domain " Rob Herring
2021-04-16 6:37 ` [PATCH 4/4] dt-bindings: arm: keystone: Convert ti,sci " Nishanth Menon
2021-04-21 22:40 ` Rob Herring
2021-04-22 14:17 ` Nishanth Menon [this message]
2021-04-22 16:12 ` Rob Herring
2021-04-16 10:37 ` [PATCH 0/4] dt-bindings: soc/arm: Convert pending ti,sci* bindings to json format Tero Kristo
2021-04-21 22:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422141744.2imrochbzzt26wx4@slush \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).