From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A27C433B4 for ; Wed, 28 Apr 2021 13:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FE6461440 for ; Wed, 28 Apr 2021 13:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240169AbhD1N7X (ORCPT ); Wed, 28 Apr 2021 09:59:23 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2940 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239246AbhD1N7L (ORCPT ); Wed, 28 Apr 2021 09:59:11 -0400 Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FVg4t2tWnz686k6; Wed, 28 Apr 2021 21:50:38 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 28 Apr 2021 15:58:25 +0200 Received: from localhost (10.52.123.69) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 28 Apr 2021 14:58:24 +0100 Date: Wed, 28 Apr 2021 14:56:50 +0100 From: Jonathan Cameron To: Sean Nyekjaer CC: , , , , , , Subject: Re: [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Message-ID: <20210428145650.000054cf@Huawei.com> In-Reply-To: <20210428082203.3587022-1-sean@geanix.com> References: <20210428082203.3587022-1-sean@geanix.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.69] X-ClientProxiedBy: lhreml751-chm.china.huawei.com (10.201.108.201) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 28 Apr 2021 10:22:00 +0200 Sean Nyekjaer wrote: > This in done for supporting hw buffered sampling > > Signed-off-by: Sean Nyekjaer Please squash into the original binding patch. Bindings should reflect the hardware features rather than what the driver happens to be currently taking advantage of. Occasionally we'll do it in multiple parts because we aren't sure what the binding will look like, but in this case you've posted this before the other has been applied so just merge them together. Thanks, Jonathan > --- > This series depends on "iio: accel: add support for > FXLS8962AF/FXLS8964AF accelerometers" > > .../bindings/iio/accel/nxp,fxls8962af.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > index c7be7a1679ab..e0e5542377df 100644 > --- a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > @@ -32,6 +32,16 @@ properties: > interrupts: > maxItems: 1 > > + interrupt-names: > + maxItems: 1 > + items: > + enum: > + - INT1 > + - INT2 > + > + drive-open-drain: > + type: boolean > + > required: > - compatible > - reg > @@ -51,6 +61,7 @@ examples: > reg = <0x62>; > interrupt-parent = <&gpio0>; > interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "INT1"; > }; > }; > - | > @@ -66,5 +77,6 @@ examples: > spi-max-frequency = <4000000>; > interrupt-parent = <&gpio0>; > interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "INT1"; > }; > };