From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A60C433ED for ; Wed, 28 Apr 2021 17:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA76D6100B for ; Wed, 28 Apr 2021 17:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241419AbhD1RBw (ORCPT ); Wed, 28 Apr 2021 13:01:52 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2947 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241235AbhD1RBw (ORCPT ); Wed, 28 Apr 2021 13:01:52 -0400 Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FVl7g1YR8z6xhS0; Thu, 29 Apr 2021 00:53:19 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 28 Apr 2021 19:01:05 +0200 Received: from localhost (10.52.123.69) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 28 Apr 2021 18:01:05 +0100 Date: Wed, 28 Apr 2021 17:59:31 +0100 From: Jonathan Cameron To: Oleksij Rempel CC: Rob Herring , Jonathan Cameron , , , "Pengutronix Kernel Team" , David Jander , "Robin van der Gracht" , , "Lars-Peter Clausen" , Peter Meerwald-Stadler , "Dmitry Torokhov" Subject: Re: [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties Message-ID: <20210428175931.00002a7e@Huawei.com> In-Reply-To: <20210428073208.19570-2-o.rempel@pengutronix.de> References: <20210428073208.19570-1-o.rempel@pengutronix.de> <20210428073208.19570-2-o.rempel@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.69] X-ClientProxiedBy: lhreml751-chm.china.huawei.com (10.201.108.201) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 28 Apr 2021 09:32:06 +0200 Oleksij Rempel wrote: > Settling time and over sampling is a typical challenge for different IIO ADC > devices. So, introduce channel specific settling-time-us and oversampling-ratio > properties to cover this use case. > > Signed-off-by: Oleksij Rempel This and patch 2 both look good to me. Given Rob gave a minor comment on the previous version I don't feel I need him to look at this again. Will pick up in a few days if no other reviews come in to require a v7. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/adc/adc.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml > index 912a7635edc4..db348fcbb52c 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml > @@ -39,4 +39,16 @@ properties: > The first value specifies the positive input pin, the second > specifies the negative input pin. > > + settling-time-us: > + description: > + Time between enabling the channel and first stable readings. > + > + oversampling-ratio: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Oversampling is used as replacement of or addition to the low-pass filter. > + In some cases, the desired filtering characteristics are a function the > + device design and can interact with other characteristics such as > + settling time. > + > additionalProperties: true