From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F]
Date: Fri, 7 May 2021 11:49:33 +0200 [thread overview]
Message-ID: <20210507094933.dxtwm7vnr6ijqtup@pengutronix.de> (raw)
In-Reply-To: <20200822125611.GB30094@dragon>
[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]
Hello Shawn,
digging through my mailbox of unarchived mails I found this patch.
On Sat, Aug 22, 2020 at 08:56:12PM +0800, Shawn Guo wrote:
> On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-König wrote:
> > The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as
>
> Is this how i.MX25 RM names the function?
The reference manual (Rev. 2; 01/2011) doesn't give a name. The relevant
description for the GPIO_A pad reads:
MUX Mode Select Field. Select 1 of 7 iomux modes to be used for pad: GPIO_A.
000: Select mux mode: ALT0 mux port: GPIO[0] of instance: gpio1.
...
So I'd say: GPIO_A is the pad name (only) and the function is better
named GPIO_1_0.
Best regards
Uwe
> > done for all the other pins with GPIO functionality. Fix for consistency.
> >
> > There are no mainline users that needs adaption.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h
> > index e14140e62b9b..55948e668410 100644
> > --- a/arch/arm/boot/dts/imx25-pinfunc.h
> > +++ b/arch/arm/boot/dts/imx25-pinfunc.h
> > @@ -563,15 +563,15 @@
> > #define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000
> > #define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000
> >
> > -#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000
> > +#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000
> > #define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000
> > #define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000
> > [...]
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-07 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 8:47 [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Uwe Kleine-König
2020-08-22 12:56 ` Shawn Guo
2021-05-07 9:49 ` Uwe Kleine-König [this message]
2021-05-11 1:39 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507094933.dxtwm7vnr6ijqtup@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).