From: Shawn Guo <shawnguo@kernel.org>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
catalin.marinas@arm.com, will@kernel.org,
bjorn.andersson@linaro.org, krzk@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support
Date: Tue, 11 May 2021 10:22:23 +0800 [thread overview]
Message-ID: <20210511022222.GB3425@dragon> (raw)
In-Reply-To: <20210331232356.2204476-3-adrien.grassein@gmail.com>
On Thu, Apr 01, 2021 at 01:23:54AM +0200, Adrien Grassein wrote:
> Add the description for the USB host port.
> This port is linked to a resettable USB HUB so handle
> this reset signal with a GPIO hog.
>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
> .../boot/dts/freescale/imx8mq-nitrogen.dts | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> index b46f45a82be1..04992cbba56e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> @@ -102,6 +102,14 @@ ethphy0: ethernet-phy@4 {
> };
> };
>
> +&gpio1 {
> + usb-host-reset-hog {
> + gpio-hog;
> + gpios = <14 GPIO_ACTIVE_HIGH>;
> + output-high;
> + };
> +};
> +
> &i2c1 {
> clock-frequency = <400000>;
> pinctrl-names = "default";
> @@ -213,6 +221,22 @@ &usb3_phy0 {
> status = "okay";
> };
>
> +&usb_dwc3_1 {
> + dr_mode = "host";
> + status = "okay";
> +};
> +
> +/*
> + * On this board, USB host is connected to a resettable hub.
> + * The reset signal is connected to the GPIO <&gpio1 14 GPIO_ACTIVE_LOW>.
> + * You need to activate it in the bootloader or in the userspace.
> + */
> +&usb3_phy1 {
> + status = "okay";
We usually end property list with 'status'.
Shawn
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb3_1>;
> +};
> +
> &usdhc1 {
> assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
> assigned-clock-rates = <400000000>;
> @@ -388,6 +412,12 @@ MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC 0x16
> >;
> };
>
> + pinctrl_usb3_1: usb3-1grp {
> + fsl,pins = <
> + MX8MQ_IOMUXC_GPIO1_IO14_GPIO1_IO14 0x16
> + >;
> + };
> +
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x83
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-05-11 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 23:23 [PATCH v3 0/4] Add peripheral support to imx8mq-nitrogen board Adrien Grassein
2021-03-31 23:23 ` [PATCH v3 1/4] arm64: dts: imx8mq-nitrogen: add USB OTG support Adrien Grassein
2021-03-31 23:23 ` [PATCH v3 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support Adrien Grassein
2021-05-11 2:22 ` Shawn Guo [this message]
2021-03-31 23:23 ` [PATCH v3 3/4] arm64: dts: imx8mq-nitrogen: add lt8912 MIPI-DSI to HDMI Adrien Grassein
2021-05-11 2:27 ` Shawn Guo
2021-05-11 19:36 ` Adrien Grassein
2021-03-31 23:23 ` [PATCH v3 4/4] arm64: defconfig: Enable LT8912B DRM bridge driver Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511022222.GB3425@dragon \
--to=shawnguo@kernel.org \
--cc=adrien.grassein@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).