From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D4BC433ED for ; Fri, 21 May 2021 13:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D67C9613CB for ; Fri, 21 May 2021 13:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232475AbhEUNxE (ORCPT ); Fri, 21 May 2021 09:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbhEUNxD (ORCPT ); Fri, 21 May 2021 09:53:03 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB45C061574 for ; Fri, 21 May 2021 06:51:40 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id y14so19079089wrm.13 for ; Fri, 21 May 2021 06:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FoMElIb6Izgq7UZS50abk10HVNabRz/+764pqMn/JqU=; b=CLRCB/Mbb5LgIbp3HOvQxnrbgHS+bKMVfkyBTqp6NKWhozzynf9yluLagrU3GqKpeu m6HjbjBuOZHO6lrzim1FHhS9RRrM8m5wkxK0H/LBmdTNqrJkJh2U1ynk12Nxp+yiQFqI ifxAWvGfMOzN6TZHgIKtK1hxGieLVr7asIAaJSA2NCTcX/6ujDAMAFWVpXq0jjOM7Goc yMlMZ/aNdcjKFXain9COtjN0j4DEM4uGUiHkaxGLJ6lVHY0rn6nAc+Vp8YlF895JOciF vv2U05Piae+I1uE6pZdK/xj7huLLFifIsq5s2QDzX4+WzgW50gkAzY3wxmkYL6RaJ5Sr IZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoMElIb6Izgq7UZS50abk10HVNabRz/+764pqMn/JqU=; b=Qb+aZ+gJFDC1PHRnlasU8GccuE7KI+UbjWCSPDG7dQdA1klhftmMNztvhhNYn1lIbV yxISj0GjoxRGWO25SbHTYqaOjm53R3f+fdu+AngBodaSbPdmef1F0LvhJcmYL+E/GYGh WDfwzp+826v6nn2ZaheSoto0H2ScVew5V7ZDtfQb6xzSN0AMev0OpdElI6RQEmumHh+I rjESaxpRfCZi0AGGq0kmaYW8Gx3CuWLabZJlrjEpAlYW1R1gplnQ0B2Bc7IZ2xR4Q7x3 Kii2IaQT2Qj5CYMUbqWQNNfViAleq/j6utz3skeaxtIyTpyUJ1fbruPItZi9HIKmCtcU 3M/w== X-Gm-Message-State: AOAM530b66p7dpYTEdsucQp2dW1Hal77onZjA4fL6oF13fBXU/eo//Sq MolMRgMqk65Y7BSSXfcPOyCHvg== X-Google-Smtp-Source: ABdhPJx9xSuKQ62LE/28tjl5IJOkDRAgdB+i5aV0N3ZjddgaHxOc1hhhp/80oCXec1SfZiTopcMIhg== X-Received: by 2002:a5d:44cb:: with SMTP id z11mr9919832wrr.159.1621605099373; Fri, 21 May 2021 06:51:39 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id x2sm6001300wmj.3.2021.05.21.06.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 06:51:38 -0700 (PDT) Date: Fri, 21 May 2021 14:51:37 +0100 From: Lee Jones To: Rob Herring Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , devicetree@vger.kernel.org, linux-arm-kernel , Florian Fainelli , Vivek Unune , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Linus Walleij Subject: Re: [PATCH V3 robh dt/next] dt-bindings: mfd: add Broadcom CRU Message-ID: <20210521135137.GG2549456@dell> References: <20210519082049.30976-1-zajec5@gmail.com> <20210519184041.563-1-zajec5@gmail.com> <20210521071221.GU2549456@dell> <273988f1-7180-572e-f9e2-4218637d0353@gmail.com> <20210521073150.GA2549456@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 21 May 2021, Rob Herring wrote: > On Fri, May 21, 2021 at 2:31 AM Lee Jones wrote: > > > > On Fri, 21 May 2021, Rafał Miłecki wrote: > > > > > On 21.05.2021 09:12, Lee Jones wrote: > > > > On Thu, 20 May 2021, Rob Herring wrote: > > > > > > > > > On Wed, May 19, 2021 at 1:40 PM Rafał Miłecki wrote: > > > > > > > > > > > > From: Rafał Miłecki > > > > > > > > > > > > CRU is a block used in e.g. Northstar devices. It can be seen in the > > > > > > bcm5301x.dtsi and this binding documents its proper usage. > > > > > > > > > > > > Signed-off-by: Rafał Miłecki > > > > > > Reviewed-by: Rob Herring > > > > > > --- > > > > > > Rob: would you take this patch through your dt/next? > > > > > > > > > > I can't, I don't have the dependencies. It looks like 08e9fdfbb224 is > > > > > already upstream. For ac5f8197d15c, I could get a stable branch from > > > > > Linus, but I can't take some random github branch. Even if I got a > > > > > stable branch for that, that's a lot of extra work for me for 1 patch > > > > > compared to waiting til next cycle. > > > > > > > > > > My suggestion is get a stable branch/tag from Linus, merge that into > > > > > the Broadcom branch and then apply this patch. Though really, Linus > > > > > needed to know the dependency when applying the patch if he doesn't > > > > > rebase his tree. (I realize the dependency probably happened because > > > > > of the review). > > > > > > > > > > > > > > > > > V2: Use complete binding & change additionalProperties to false > > > > > > V3: Use clock-controller@ for clocks > > > > > > > > > > > > NOTICE: this patch is based on top of the linux-next as it requires: > > > > > > ac5f8197d15c ("dt-bindings: pinctrl: convert Broadcom Northstar to the json-schema") > > > > > > 08e9fdfbb224 ("dt-bindings: thermal: brcm,ns-thermal: Convert to the json-schema") > > > > > > AND merged git@github.com:Broadcom/stblinux.git devicetree/next as it requires: > > > > > > 8f711f68cffd ("dt-bindings: clock: brcm, iproc-clocks: convert to the json-schema") > > > > > > > > > > > > This is reworked version of the > > > > > > [PATCH robh next] dt-bindings: bus: add Broadcom CRU > > > > > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210309142241.16259-1-zajec5@gmail.com/ > > > > > > --- > > > > > > .../devicetree/bindings/mfd/brcm,cru.yaml | 86 +++++++++++++++++++ > > > > > > 1 file changed, 86 insertions(+) > > > > > > create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml > > > > > > > > What's the dependency here? It's a new file that doesn't reference anything. > > > > > > Without dependencies it will cause warnings for those running "dt_binding_check". > > > > No one runs that, it's full of warnings. ;) > > That's dtbs_check on dts files which is full of warnings. > dt_binding_check for the schema does not have warnings (well, there's > a couple typically because either the bindings aren't reviewed or the > dependencies are ignored). > > > > I didn't find it critical so I thought Rob can take in on a promise of > > > what is queued for the next release. It appears Rob has more strict > > > rules so I'll just have to wait for stuff to land in Linus's tree :) > > I care less if other trees break as long as linux-next doesn't. > > > Rob isn't the one taking the patch. :D > > > > I'll apply it in a few days, unless Rob shouts real-loud! > > I've said it before, MFD and their child bindings need to be applied > in 1 tree. If you can't make that happen, then don't apply binding > patches. I'm not aware of MFD patches applied anywhere else. AFAIK, they all come through me. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog