From: Maxime Ripard <maxime@cerno.tech>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Vagrant Cascadian" <vagrant@reproducible-builds.org>,
"B.R. Oake" <broake@mailfence.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode
Date: Mon, 24 May 2021 14:35:06 +0200 [thread overview]
Message-ID: <20210524123506.cuwwtqgtejquuq5e@gilmour> (raw)
In-Reply-To: <20210524122111.416885-1-carnil@debian.org>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the Orange Pi Plus board this is "rgmii", which is the
> wrong setting.
>
> Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> the Ethernet working again on this board.
>
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> Reported-by: "B.R. Oake" <broake@mailfence.com>
> Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Link: https://bugs.debian.org/988574
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-05-24 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 12:21 [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode Salvatore Bonaccorso
2021-05-24 12:35 ` Maxime Ripard [this message]
2021-07-10 13:09 ` Salvatore Bonaccorso
2021-07-10 16:02 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524123506.cuwwtqgtejquuq5e@gilmour \
--to=maxime@cerno.tech \
--cc=broake@mailfence.com \
--cc=carnil@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=vagrant@reproducible-builds.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).