From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30573C11F64 for ; Thu, 1 Jul 2021 20:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DFCC613FB for ; Thu, 1 Jul 2021 20:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236183AbhGAUgJ (ORCPT ); Thu, 1 Jul 2021 16:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236786AbhGAUgI (ORCPT ); Thu, 1 Jul 2021 16:36:08 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE6EC061765 for ; Thu, 1 Jul 2021 13:33:37 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id u19so4353547plc.3 for ; Thu, 01 Jul 2021 13:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OJw8rDzzQy3DhiLUvJQW+Qdo9Q9Meb8jwgwdAgUtwaA=; b=tjNf5cxiic1IPqklXIFZcopMA88yLPj7nHk9KKLZZCgnA0o/97EhJzWO3mqfHkg89j kAvRHnAzxJSzeRsj/R1Zs/iQhGksf/npipynnWtszL2uJSpvaki4kcXwIWo7jKepEU9z AkvXC7nruuQI0yxo9nu0Zsq5lpZMHPR9eIKAo33JCgWztrDpK9LqDUDZxTKHqX79Et+0 tOVNAqJxr7h0M31yRL/TyIChS9QJCX8yhqqE2EuHgPEvtzYiYLIRGE2d9f5vgNazBLv+ /UJF+LPAjXVH2hfPv2RyTYowAdt+Bpf0XiS2sEUhUqR5QCAmXajtoo8vcnACnaYC80CW iRHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OJw8rDzzQy3DhiLUvJQW+Qdo9Q9Meb8jwgwdAgUtwaA=; b=mckxMZV1dh/6g6x4g5jwmyIdX0avpSB3ygiIGFNgJAQpFqKCZSvxiLRMdduFzdBWUF qZ/mNLbTT8FlEJZGH1UUamfGVpz2LDwb+smyFzCIucfKq+hIHo7SQ0Q6ZjWqg6cVHBPk l1Y+P8yquHf+H8krf9pq+8uiLbIYYo4vH+Hfu/9Q70srDU8AHunmTP1i/ZSAOTM51JXz 9pfVurMe3AW/V2jTgoH26txIZSLPlv0EPliJ3//JVpvi8ohzr5W92OJ9Ebrl1eVOGDMX 7s6xFSeimp1jZ2nSsRDakHMpk8gglxc4NDUU1FxIQM9hq1oeyDy9HuNtYFZVvCupdi0L /I9g== X-Gm-Message-State: AOAM533UxgUsvIhD0lIt1yfXDxkmmzbyvNhr6FDp+cXYcJnA1arYgMJP MM+ZtfzG65kWtvfBecpgenk6WQ== X-Google-Smtp-Source: ABdhPJxg+Za0ZEhKlCUXAe3lsXSkyHKiJcX76VwoRNv8bPZ+omjAiffeUdkx0JcSCtpRpL5AW22CoA== X-Received: by 2002:a17:902:c086:b029:129:3680:32f0 with SMTP id j6-20020a170902c086b0290129368032f0mr1419861pld.47.1625171616680; Thu, 01 Jul 2021 13:33:36 -0700 (PDT) Received: from x1 ([2601:1c0:4701:ae70:8fd:ccc0:a9a:cf98]) by smtp.gmail.com with ESMTPSA id d3sm501203pjo.31.2021.07.01.13.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 13:33:35 -0700 (PDT) Date: Thu, 1 Jul 2021 13:33:33 -0700 From: Drew Fustini To: Michael Walle Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , Paul Walmsley , Palmer Dabbelt , Michael Zhu , Geert Uytterhoeven , Fu Wei , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Emil Renner Berthing , Huan Feng Subject: Re: [RFC PATH 2/2] gpio: starfive-jh7100: Add StarFive JH7100 GPIO driver Message-ID: <20210701203333.GA963857@x1> References: <20210701002037.912625-1-drew@beagleboard.org> <20210701002037.912625-3-drew@beagleboard.org> <8c59105d32a9936f8806501ecd20e044@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c59105d32a9936f8806501ecd20e044@walle.cc> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 01, 2021 at 08:39:40AM +0200, Michael Walle wrote: > Hi Drew, > > Am 2021-07-01 02:20, schrieb Drew Fustini: > > Add GPIO driver for the StarFive JH7100 SoC [1] used on the > > BeagleV Starlight JH7100 board [2]. > > > > [1] https://github.com/starfive-tech/beaglev_doc/ > > [2] https://github.com/beagleboard/beaglev-starlight > > > > Signed-off-by: Emil Renner Berthing > > Signed-off-by: Huan Feng > > Signed-off-by: Drew Fustini > > Could this driver use GPIO_REGMAP and REGMAP_IRQ? See > drivers/gpio/gpio-sl28cpld.c for an example. > > -michael Thank you for the suggestion. I am not familiar with GPIO_REGMAP and REGMAP_IRQ so I will read about it. Is the advantage is that is helps to reduce code duplication by using an abstraction? I did notice that the gpio-sifive.c driver used regmap_update_bits() and regmap_write(). I suppose that is better than writel_relaxed() and iowrite32() which this RFC driver does? thanks, drew