devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ls1028: sl28: fix networking for variant 2
@ 2021-07-02 19:49 Michael Walle
  2021-07-23  2:40 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Walle @ 2021-07-02 19:49 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, linux-kernel
  Cc: Shawn Guo, Li Yang, Rob Herring, Michael Walle

The PHY configuration for the variant 2 is still missing the flag for
in-band signalling between PHY and MAC. Both sides - MAC and PHY - have
to match the setting. For now, Linux only supports setting the MAC side
and thus it has to match the setting the bootloader is configuring.
Enable in-band signalling to make ethernet work.

Fixes: ab43f0307449 ("arm64: dts: ls1028a: sl28: add support for variant 2")
Signed-off-by: Michael Walle <michael@walle.cc>
---
What make things worse and why this might slipped through is that the
setting in the PHY is persistent even after a soft reset of the PHY.

 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
index dd764b720fb0..f6a79c8080d1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
@@ -54,6 +54,7 @@
 
 &mscc_felix_port0 {
 	label = "swp0";
+	managed = "in-band-status";
 	phy-handle = <&phy0>;
 	phy-mode = "sgmii";
 	status = "okay";
@@ -61,6 +62,7 @@
 
 &mscc_felix_port1 {
 	label = "swp1";
+	managed = "in-band-status";
 	phy-handle = <&phy1>;
 	phy-mode = "sgmii";
 	status = "okay";
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: ls1028: sl28: fix networking for variant 2
  2021-07-02 19:49 [PATCH] arm64: dts: ls1028: sl28: fix networking for variant 2 Michael Walle
@ 2021-07-23  2:40 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-07-23  2:40 UTC (permalink / raw)
  To: Michael Walle
  Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring

On Fri, Jul 02, 2021 at 09:49:14PM +0200, Michael Walle wrote:
> The PHY configuration for the variant 2 is still missing the flag for
> in-band signalling between PHY and MAC. Both sides - MAC and PHY - have
> to match the setting. For now, Linux only supports setting the MAC side
> and thus it has to match the setting the bootloader is configuring.
> Enable in-band signalling to make ethernet work.
> 
> Fixes: ab43f0307449 ("arm64: dts: ls1028a: sl28: add support for variant 2")
> Signed-off-by: Michael Walle <michael@walle.cc>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-23  2:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 19:49 [PATCH] arm64: dts: ls1028: sl28: fix networking for variant 2 Michael Walle
2021-07-23  2:40 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).