From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E5DC07E98 for ; Fri, 2 Jul 2021 21:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54349613F8 for ; Fri, 2 Jul 2021 21:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231831AbhGBVCt (ORCPT ); Fri, 2 Jul 2021 17:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbhGBVCs (ORCPT ); Fri, 2 Jul 2021 17:02:48 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C63C061765 for ; Fri, 2 Jul 2021 14:00:14 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id m26so10875835pgb.8 for ; Fri, 02 Jul 2021 14:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oOQvjNwUs6iGdF4qU2K20XA2rSMaHeKg3ys4j3WcHnc=; b=hYM4Px7OvwbK9XsUFZfo1RxGbzj90AUFJXgJwyByTUvzILGgndzmwMbIeL8chJCL/1 jnLgsfXFcJORybUzJlR8Ts4om5iI3vfYCOOaOGhcbqNDqPf5G9HIQDmb575aYR+2mMcB UHULog5A9xsnm2hD6O+LvitJflAiWtuUlsSp8b1zC1z+F+GtjwFOkmoxUpEr7qnFab+S K4eS+ZSOYZqUI8WwZwd1Xylpf6Tsx1ULc6iiDVbo5T58XZunv+/TzmElGmJCmEBO3KQ4 9Mgj+VUVg1GWSmLadoePcZyVGiDpn3Gx6gFsQyDn3LxMUHibgihro9oW4eb8GFKbtJ+X rfTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oOQvjNwUs6iGdF4qU2K20XA2rSMaHeKg3ys4j3WcHnc=; b=Yf1pPwa4H7DilQL1USffpRboRqS5YEeq06iKI0NqI329kPHTuJDC/1ztX+UB4NaG3f jOiZT8nBaHk385CzHEBY2bo3avON3dKSZ1MHqZFNr+Ju4VrB+xvZWCMDx2P/H81wcIP5 fG2SWvueLPZXSReP3VR6JjACIvI7muVDncvLQkPUtVyZ1Zeeb1lACFh4y8fQ4h6WQ2F9 951JNM+UDexU418IbHOr2N3HVvBILg1Fd+8RTAlXZc7nL5F0153MqNgV6GAavbyGhdwZ bKVFIpIRO/2mmTVGHfrGlx2qTIPavODChaAjiEAsqLWrMC0uc0bSwTUbB4du6zFzopQu HIeQ== X-Gm-Message-State: AOAM533VQxEYLPgw+JtuiLsiRctpJ4uJc8IyDfVNMBEvXznFabHcvb4t VJeVFU6Yf41t1Bh3aGPEb4FeVA== X-Google-Smtp-Source: ABdhPJwX6MC0pslJVSWjiHUEQMYnxqyk6w0QgIpJI+wow/rFNf/BdwqJWoRkWhXswPubyBwBxdmobA== X-Received: by 2002:a62:7950:0:b029:30f:cffa:a25e with SMTP id u77-20020a6279500000b029030fcffaa25emr1324959pfc.50.1625259614259; Fri, 02 Jul 2021 14:00:14 -0700 (PDT) Received: from x1 ([2601:1c0:4701:ae70:f236:257f:88f9:445e]) by smtp.gmail.com with ESMTPSA id 11sm4742618pge.7.2021.07.02.14.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 14:00:13 -0700 (PDT) Date: Fri, 2 Jul 2021 14:00:10 -0700 From: Drew Fustini To: Michael Walle , g@x1 Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , Paul Walmsley , Palmer Dabbelt , Michael Zhu , Geert Uytterhoeven , Fu Wei , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Emil Renner Berthing , Huan Feng Subject: Re: [RFC PATH 2/2] gpio: starfive-jh7100: Add StarFive JH7100 GPIO driver Message-ID: <20210702210010.GB1035183@x1> References: <20210701002037.912625-1-drew@beagleboard.org> <20210701002037.912625-3-drew@beagleboard.org> <8c59105d32a9936f8806501ecd20e044@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c59105d32a9936f8806501ecd20e044@walle.cc> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 01, 2021 at 08:39:40AM +0200, Michael Walle wrote: > Hi Drew, > > Am 2021-07-01 02:20, schrieb Drew Fustini: > > Add GPIO driver for the StarFive JH7100 SoC [1] used on the > > BeagleV Starlight JH7100 board [2]. > > > > [1] https://github.com/starfive-tech/beaglev_doc/ > > [2] https://github.com/beagleboard/beaglev-starlight > > > > Signed-off-by: Emil Renner Berthing > > Signed-off-by: Huan Feng > > Signed-off-by: Drew Fustini > > Could this driver use GPIO_REGMAP and REGMAP_IRQ? See > drivers/gpio/gpio-sl28cpld.c for an example. > > -michael I looked more at the example. Do you have a suggestion of how to handle different types of interrupts? This gpio controller can handle level triggered and edge triggered. Edge triggered can be positve, negative or both. Level trigger can be high or low. Thanks, Drew