From: Shawn Guo <shawn.guo@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: qcom,pon: Add 'qcom,mode-in-imem' support
Date: Mon, 5 Jul 2021 10:41:32 +0800 [thread overview]
Message-ID: <20210705024131.GA11342@dragon> (raw)
In-Reply-To: <YOGArXunEf2O58gL@gerhold.net>
On Sun, Jul 04, 2021 at 11:36:41AM +0200, Stephan Gerhold wrote:
> On Sun, Jul 04, 2021 at 03:40:44PM +0800, Shawn Guo wrote:
> > It's not always the case that reboot mode value gets stored in PON
> > register. For example, Sony Xperia M4 Aqua phone (MSM8939) uses a
> > different set of mode value and stores them in IMEM. Add property
> > 'qcom,mode-in-imem' to distinguish this mechanism from the existing one.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > .../bindings/power/reset/qcom,pon.yaml | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > index 7764c804af1d..a6270e39b7a2 100644
> > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > @@ -23,6 +23,10 @@ properties:
> > reg:
> > maxItems: 1
> >
> > + qcom,mode-in-imem:
> > + description: Reboot mode is stored in IMEM rather than PON register
> > + type: boolean
> > +
> > patternProperties:
> > "^mode-.+":
> > $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -35,6 +39,7 @@ required:
> > additionalProperties: false
> >
> > examples:
> > + # Example 1: Reboot mode is stored in PON register
> > - |
> > pmic {
> > #address-cells = <1>;
> > @@ -47,3 +52,17 @@ examples:
> > mode-recovery = <0x1>;
> > };
> > };
> > + # Example 2: Reboot mode is stored in IMEM
> > + - |
> > + pmic {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pon@800 {
> > + compatible = "qcom,pm8916-pon";
> > + reg = <0x860065c>;
>
> This is quite strange. pon@800 is a node of the PM8916 PMIC,
> so the reg should refer to the address inside the PMIC, not some memory
> address of the SoC. dtc will probably warn about this too since the unit
> address (@800) should match the first reg. (At least on W=1.)
Fair point.
> Actually we already have some devices using IMEM for the reboot mode,
> like this (qcom-msm8974.dtsi plus qcom-msm8974-fairphone-fp2.dts):
>
> imem@fe805000 {
> compatible = "syscon", "simple-mfd";
> reg = <0xfe805000 0x1000>;
>
> reboot-mode {
> compatible = "syscon-reboot-mode";
> offset = <0x65c>;
> mode-normal = <0x77665501>;
> mode-bootloader = <0x77665500>;
> mode-recovery = <0x77665502>;
> };
> };
>
> Perhaps it would be cleaner to add a property to disable the reboot mode
> functionality of pm8916-pon and then set it up like this?
Ah, yes, this is sensible. Thanks for the msm8974 example!
Shawn
next prev parent reply other threads:[~2021-07-05 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 7:40 [PATCH 0/3] Add 'qcom,mode-in-imem' support in PON driver Shawn Guo
2021-07-04 7:40 ` [PATCH 1/3] dt-bindings: power: reset: Convert qcom,pon to DT schema Shawn Guo
2021-07-04 7:40 ` [PATCH 2/3] dt-bindings: qcom,pon: Add 'qcom,mode-in-imem' support Shawn Guo
2021-07-04 9:36 ` Stephan Gerhold
2021-07-05 2:41 ` Shawn Guo [this message]
2021-07-04 7:40 ` [PATCH 3/3] power: reset: qcom-pon: Add support for 'qcom,mode-in-imem' Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705024131.GA11342@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).