From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FFFC07E9A for ; Wed, 14 Jul 2021 11:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAF25613B9 for ; Wed, 14 Jul 2021 11:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239247AbhGNLxD (ORCPT ); Wed, 14 Jul 2021 07:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230405AbhGNLxD (ORCPT ); Wed, 14 Jul 2021 07:53:03 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76A9C061760 for ; Wed, 14 Jul 2021 04:50:11 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id s18so2135422pgq.3 for ; Wed, 14 Jul 2021 04:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=12eUwpVE7CCQZhGXg14kXDSLP4TmS3iMl6QBgv+GuyM=; b=aR8wGXsU9AUVloF0vq84zNnI1tiULt8B/IkHWnmf0p5pHo4rKruxk2ny33782nnSIi LPwpj3OIvziPLYKu+WL8900Gmnw0HyFcWbYbscV916y1hzsrwENc+fJ86ar83u3xCxd4 JKr/6gQqzfnR+PIS5zUJlI5xF6UbTTG1LLba/g8tMbqXDsCpDntnDYHIopcSm53sZl18 BaCKTck+j/FBHZ0VoIPlaF6xPffYr3nkBwrDgyVYmiOa80UlY9z5lXzQrffMN3d+rByh Ol9vVy8udujUhDs7x+D7ZaYD15dVAUyoxx5thpx7A5vndmKP/DHwiDV6e15rKn8BdoTR gjaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=12eUwpVE7CCQZhGXg14kXDSLP4TmS3iMl6QBgv+GuyM=; b=akSuqtrRffdA3FJhSAFNxPgN0ZTbFD5R3k0+Q/dxny4X5sCo6hvAbZfIKXICGOPYC8 rIHGW4jv+sSnE+TWag0qW4CJQxGZXRUu4rNI7brIEK/MwKTvACe82Mf2sCdULaREQl1G 4OVbQD/yT6meVmt0PFq83t+MD5iCIUWbqJ+1+5frh/nxZU1P0Gb2H4iUyNQqVhdTHLrq E6LfP5+r/z45+7iQ6wx9+fX3TPu3NybTjxoe9t8L/Z4G+KVp/8YJsgboLke1Miy0+7X8 49wqA4CH6fIivca+RffYoZSK0CpfCSamVF3reir8qaivV8H/70jbWhSVuS6+1maySngH XcRA== X-Gm-Message-State: AOAM530K212DeL42j1psERFVJCJGxg5wonkyzyD8p4qmrsqMz+khjq06 hvRsF7QUbhg2sAhV+CvfCB3cBQ== X-Google-Smtp-Source: ABdhPJw8nHTd49BGH+pFXxggh0xJxXK2Zr+pmXZvKNrQ0nzbopfvHY/TIF53CEGmNxw0EfkUdkYe7A== X-Received: by 2002:aa7:9a08:0:b029:331:ea96:691d with SMTP id w8-20020aa79a080000b0290331ea96691dmr1301133pfj.75.1626263411418; Wed, 14 Jul 2021 04:50:11 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id e30sm2879336pga.63.2021.07.14.04.50.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 04:50:11 -0700 (PDT) Date: Wed, 14 Jul 2021 19:49:57 +0800 From: Shawn Guo To: Bjorn Andersson Cc: Sebastian Reichel , Stephan Gerhold , Rob Herring , Vinod Koul , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] power: reset: qcom-pon: Add support for 'qcom,pon-reboot-not-used' Message-ID: <20210714114957.GF11342@dragon> References: <20210705025032.12804-1-shawn.guo@linaro.org> <20210705025032.12804-4-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 12, 2021 at 12:12:26PM -0500, Bjorn Andersson wrote: > On Sun 04 Jul 21:50 CDT 2021, Shawn Guo wrote: > > > Check property 'qcom,pon-reboot-not-used' and skip reboot-mode setup > > if the property is present. This is useful for devices that use IMEM > > instead of PON register to pass reboot mode, but still want to populate > > pwrkey and resin devices. > > > > If IMEM is used instead, I think it should be sufficient for the DT > author to omit mode-* properties to achieve this. Indeed! This is much better solution. Thanks for the suggestion! So please disregard patch #2 and #3, and I will resend #1 as a separate patch. Shawn > If the PON hardware > doesn't support mode-*, then that should be reflected in the DT binding > and compatible.