From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72380C07E9B for ; Mon, 19 Jul 2021 10:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E0A261026 for ; Mon, 19 Jul 2021 10:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236185AbhGSJxA (ORCPT ); Mon, 19 Jul 2021 05:53:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236171AbhGSJxA (ORCPT ); Mon, 19 Jul 2021 05:53:00 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67501C061762 for ; Mon, 19 Jul 2021 02:40:24 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id p14-20020a17090ad30eb02901731c776526so13859813pju.4 for ; Mon, 19 Jul 2021 03:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K40Jyf6F4VypIX0uQQ58aazesoLZiATF2ozlOf/u82E=; b=tm6QKxQaVJ1rfx4hcKqkfQh+kNZs1qfo7yu8WQJ/aS2+N/K/j3hAC7EJoGOLcI7mki RbXLpX3EUAsaeCKfy7dK+lsB9pV6bpejySCGNZ0YrrUbjtL9cXrDtvYSaEOtKyH8Yl2h pQwq59Y80QoFdRlHXZ8BxNEhIWPeZUnsy31tQXJKRws0GQIqiqzGSSdf27UDzkXZs8WU e1QslQq68CgzpzJ9WZD1zQIK/3f5QCVmqRqT17KzPkbNDIEwoysrIasghiLrG6lc43/K 0V/1IrT6lyVKAbt3+yYq/dWQNyTPcSMQk5oAmymYYQz6722hEl9bSCG0440pYjIpbs0r hcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K40Jyf6F4VypIX0uQQ58aazesoLZiATF2ozlOf/u82E=; b=Wauyx4cjbQFYGOIYyO9zWaagT26kfKPEdWPoTxMwOlxCLyV5nKjmSpxp8Pw1JK58Uk cYEayhJZMdE/vzWfAYNEGTQUcq/vAn63Ew6SpZY243fuQXcy0BWMfgsme++05Ol7O0jg tNmkgvZyZDoUYmAvdM/D1Nl/t7RUT/GoT7oGIueLMOB8G+0dJnEvIiaHBzniAHWYw6zU pYfWXULfLd0N81AmxszsWIs9YboNawWJQR80vtBzVvAVIk2R7vouqwyz97r8x6jeqSm/ LtAW1PmVpYvOwqGh0KBwiMRYvxjrm3HcTbLu0T03NIGuR3HAueg0SLvjFjyQTQlvI3Ou 7LBA== X-Gm-Message-State: AOAM533HIXlG1DiZAR54PlhhKKY3yv0dMwx0IJ+kKd9LASSw5NQnyxQV KuxOqKaHwAl6tq94cw9AK1x4Pg== X-Google-Smtp-Source: ABdhPJwl4MXidm+h6UyC6mKBdXmjy/5RSub0SZcKsJot16gWN5QT/b3nRghByFFqbqrk8t4XWLYxlA== X-Received: by 2002:a17:90a:b284:: with SMTP id c4mr24363136pjr.213.1626690819793; Mon, 19 Jul 2021 03:33:39 -0700 (PDT) Received: from localhost ([106.201.108.2]) by smtp.gmail.com with ESMTPSA id w5sm19850101pfq.130.2021.07.19.03.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 03:33:38 -0700 (PDT) Date: Mon, 19 Jul 2021 16:03:36 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: Rob Herring , Jason Wang , "Michael S. Tsirkin" , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , Alex =?utf-8?Q?Benn=C3=A9e?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , "linux-kernel@vger.kernel.org" , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Subject: Re: [PATCH 1/5] dt-bindings: virtio: mmio: Add support for device subnode Message-ID: <20210719103336.oyz6dppd5jf65w4m@vireshk-i7> References: <20210713151917.zouwfckidnjxvohn@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14-07-21, 23:07, Arnd Bergmann wrote: > On Wed, Jul 14, 2021 at 5:43 PM Rob Herring wrote: > > I guess it comes down to is 'virtio,mmio' providing a bus or is it > > just a device? I guess a bus (so 2 nodes) does make sense here. > > 'virtio,mmio' defines how you access/discover the virtio queues (the > > bus) and the functional device (i2c, gpio, iommu, etc.) is accessed > > via the virtio queues. > > It's not really a bus since there is only ever one device behind it. > A better analogy would be your 'serdev' framework: You could > have a 8250 or a pl011 uart, and behind that have a mouse, GPS > receiver or bluetooth dongle. > > In Documentation/devicetree/bindings/serial/serial.yaml, you also > have two nodes for a single device, so we could follow that > example. So two device nodes is final then ? Pretty much like how this patchset did it already ? I need to get rid of reg thing and use "virtio,DID" though. -- viresh