From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5252FC4338F for ; Fri, 23 Jul 2021 08:36:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A81960E93 for ; Fri, 23 Jul 2021 08:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234442AbhGWH4S (ORCPT ); Fri, 23 Jul 2021 03:56:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:41116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234276AbhGWH4R (ORCPT ); Fri, 23 Jul 2021 03:56:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFD5760E77; Fri, 23 Jul 2021 08:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627029405; bh=UyVuqNmKaOLCkr5dhRsTE6bDJ2Pg+oAGurbYq8p5lCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KfuwdXTzWBtlxfv0mIC7O1od0ef4CDsyZVwt9YRDw7Wa+5LKnmAY/6u6zLocwlLnG IHlcmVYX+x3AtEtWkH3dxTiqO72OkhkDEh4C4A65HQknRypiegceZ5QBgfk3ORvRD4 ifmguEpWfA41wmXWOERXnC1+B4E3MBAI2nVc6/MyTrPs4gD97V4R7JPHHpxE1tVyOM agh3gOQ9UYo/P3BrMwhMrWNtj5ClCgR4quLoyJ+kHFLM73qo3+c2qKVgFMySXfecuT 3qEGaYfcmTUMGsOtEr/oDb+BVKlnOlkKTC8zSqWqqI0ar/4SJJ0hKa1ejtzkNoQgHN MYDHcHVuwo1HA== Date: Fri, 23 Jul 2021 16:36:41 +0800 From: Shawn Guo To: Mathew McBride Cc: Li Yang , Ioana Ciornei , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/5] arm64: dts: ls1088a: add missing PMU node Message-ID: <20210723083640.GJ30773@dragon> References: <20210722042450.11862-1-matt@traverse.com.au> <20210722042450.11862-3-matt@traverse.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722042450.11862-3-matt@traverse.com.au> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 22, 2021 at 04:24:47AM +0000, Mathew McBride wrote: > The Performance Manager Unit was not described in the DTS > which meant performance event monitoring was not possible. > > This was exposed by a change to the PMU handling in KVM > in 5.11-rc3 which now prevents a PMU being exposed to a > guest when the host does not provide one: > "KVM: arm64: Don't access PMCR_EL0 when no PMU is available" > > Signed-off-by: Mathew McBride > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 79ceadc9dc4a..752c7f41e6b1 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -189,6 +189,11 @@ timer { > <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */ > }; > > + pmu { > + compatible = "arm,armv8-pmuv3"; > + interrupts = <1 7 0x8>; /* PMU PPI, Level low type */ Use define GIC_PPI and IRQ_TYPE_LEVEL_LOW, so that you can drop the comment. Shawn > + }; > + > psci { > compatible = "arm,psci-0.2"; > method = "smc"; > -- > 2.30.1 >