From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5706BC4320A for ; Fri, 23 Jul 2021 14:45:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 309B660EBC for ; Fri, 23 Jul 2021 14:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235376AbhGWOEw (ORCPT ); Fri, 23 Jul 2021 10:04:52 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3465 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbhGWOEw (ORCPT ); Fri, 23 Jul 2021 10:04:52 -0400 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GWWyy2v0dz6H7LH; Fri, 23 Jul 2021 22:33:46 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 23 Jul 2021 16:45:23 +0200 Received: from localhost (10.210.170.238) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 23 Jul 2021 15:45:22 +0100 Date: Fri, 23 Jul 2021 15:44:56 +0100 From: Jonathan Cameron To: Billy Tsai CC: , , , , , , , , , , , , Subject: Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Message-ID: <20210723154456.00006744@Huawei.com> In-Reply-To: <20210723081621.29477-2-billy_tsai@aspeedtech.com> References: <20210723081621.29477-1-billy_tsai@aspeedtech.com> <20210723081621.29477-2-billy_tsai@aspeedtech.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.170.238] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 23 Jul 2021 16:16:14 +0800 Billy Tsai wrote: > The aspeed,ast2400-adc.yaml not only descriptor the bindings of ast2400. > Rename it to aspeed,adc.yaml for all of the aspeed adc bindings. > > Signed-off-by: Billy Tsai We try to avoid 'wild' card type namings most of the time and instead name after a particular part number. I say try because clearly we let a few in over the years :( It is very hard to know if this binding will apply to 'all' future aspeed ADCs. As such I'm not sure this particular rename makes sense. Thanks, Jonathan > --- > .../iio/adc/{aspeed,ast2400-adc.yaml => aspeed,adc.yaml} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename Documentation/devicetree/bindings/iio/adc/{aspeed,ast2400-adc.yaml => aspeed,adc.yaml} (93%) > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml b/Documentation/devicetree/bindings/iio/adc/aspeed,adc.yaml > similarity index 93% > rename from Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > rename to Documentation/devicetree/bindings/iio/adc/aspeed,adc.yaml > index 7f534a933e92..23f3da1ffca3 100644 > --- a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed,adc.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml# > +$id: http://devicetree.org/schemas/iio/adc/aspeed,adc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: ADC that forms part of an ASPEED server management processor.