From: Mark Brown <broonie@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Michael.Hennerich@analog.com, alexandru.ardelean@analog.com,
jic23@kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de, Dragos.Bogdan@analog.com,
Darius.Berghe@analog.com
Subject: Re: [PATCH v2 2/2] iio: accel: Add driver support for ADXL355
Date: Fri, 23 Jul 2021 18:47:51 +0100 [thread overview]
Message-ID: <20210723174751.GL5221@sirena.org.uk> (raw)
In-Reply-To: <20210723184404.0000001d@Huawei.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Fri, Jul 23, 2021 at 06:44:04PM +0100, Jonathan Cameron wrote:
> Mark Brown <broonie@kernel.org> wrote:
> > > @Mark. This has come up a few times recently. Are we now safe to assume
> > > that regmap will always copy data when used with SPI and hence we no
> > > longer need to ensure DMA safe buffers?
> > Only for single register I/O, I'd not assume that for things like raw
> > I/O.
> Thanks for the confirmation. So in this driver that means we
> need DMA safe buffers for the regmap_bulk_ calls. Easiest approach
> is probably to use a __cacheline_aligned buffer at the end of the
> iio_priv() structure.
Yeah, it might be fine depending on the bus/format type but it's not
something you can generally assume.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-23 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 6:21 [PATCH v2 0/2] iio: accel: add support for ADXL355 Puranjay Mohan
2021-07-22 6:21 ` [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices Puranjay Mohan
2021-07-23 16:29 ` Jonathan Cameron
2021-07-24 15:46 ` Puranjay Mohan
2021-07-22 6:21 ` [PATCH v2 2/2] iio: accel: Add driver support for ADXL355 Puranjay Mohan
2021-07-22 7:10 ` Alexandru Ardelean
2021-07-23 16:28 ` Jonathan Cameron
2021-07-23 17:10 ` Jonathan Cameron
2021-07-23 17:14 ` Mark Brown
2021-07-23 17:44 ` Jonathan Cameron
2021-07-23 17:47 ` Mark Brown [this message]
2021-07-24 15:53 ` Puranjay Mohan
2021-07-25 15:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723174751.GL5221@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).