From: Shawn Guo <shawnguo@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config
Date: Mon, 26 Jul 2021 09:01:40 +0800 [thread overview]
Message-ID: <20210726010139.GB5901@dragon> (raw)
In-Reply-To: <CAJ+vNU3wtJ+N0XtVw6Ka+jZVKcKKmPhs+6O+dDqKQhpi3tB9ew@mail.gmail.com>
On Sat, Jul 24, 2021 at 11:19:21AM -0700, Tim Harvey wrote:
> On Tue, Jun 1, 2021 at 10:49 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > Fix various MP5416 PMIC configurations:
> > - Update regulator names per dt-bindings
> > - ensure values fit among valid register values
> > - add required regulator-max-microamp property
> > - add regulator-always-on prop
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++-------
> > 1 file changed, 37 insertions(+), 19 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> > index 512b76cd7c3b..f4eb827baed7 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> > @@ -283,65 +283,83 @@
> > reg = <0x69>;
> >
> > regulators {
> > + /* vdd_0p95: DRAM/GPU/VPU */
> > buck1 {
> > - regulator-name = "vdd_0p95";
> > - regulator-min-microvolt = <805000>;
> > + regulator-name = "buck1";
> > + regulator-min-microvolt = <800000>;
> > regulator-max-microvolt = <1000000>;
> > - regulator-max-microamp = <2500000>;
> > + regulator-min-microamp = <3800000>;
> > + regulator-max-microamp = <6800000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_soc */
> > buck2 {
> > - regulator-name = "vdd_soc";
> > - regulator-min-microvolt = <805000>;
> > + regulator-name = "buck2";
> > + regulator-min-microvolt = <800000>;
> > regulator-max-microvolt = <900000>;
> > - regulator-max-microamp = <1000000>;
> > + regulator-min-microamp = <2200000>;
> > + regulator-max-microamp = <5200000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_arm */
> > buck3_reg: buck3 {
> > - regulator-name = "vdd_arm";
> > - regulator-min-microvolt = <805000>;
> > + regulator-name = "buck3";
> > + regulator-min-microvolt = <800000>;
> > regulator-max-microvolt = <1000000>;
> > - regulator-max-microamp = <2200000>;
> > - regulator-boot-on;
> > + regulator-min-microamp = <3800000>;
> > + regulator-max-microamp = <6800000>;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_1p8 */
> > buck4 {
> > - regulator-name = "vdd_1p8";
> > + regulator-name = "buck4";
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-max-microamp = <500000>;
> > + regulator-min-microamp = <2200000>;
> > + regulator-max-microamp = <5200000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* nvcc_snvs_1p8 */
> > ldo1 {
> > - regulator-name = "nvcc_snvs_1p8";
> > + regulator-name = "ldo1";
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-max-microamp = <300000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_snvs_0p8 */
> > ldo2 {
> > - regulator-name = "vdd_snvs_0p8";
> > + regulator-name = "ldo2";
> > regulator-min-microvolt = <800000>;
> > regulator-max-microvolt = <800000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_0p9 */
> > ldo3 {
> > - regulator-name = "vdd_0p95";
> > - regulator-min-microvolt = <800000>;
> > - regulator-max-microvolt = <800000>;
> > + regulator-name = "ldo3";
> > + regulator-min-microvolt = <900000>;
> > + regulator-max-microvolt = <900000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> >
> > + /* vdd_1p8 */
> > ldo4 {
> > - regulator-name = "vdd_1p8";
> > + regulator-name = "ldo4";
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > regulator-boot-on;
> > + regulator-always-on;
> > };
> > };
> > };
> > --
> > 2.17.1
> >
>
> Shawn,
>
> Is there anything you want changed here?
Tim,
Could you resend the series? For some reason, I cannot find the
original posting in my mailbox.
Shawn
next prev parent reply other threads:[~2021-07-26 1:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 17:49 [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp Tim Harvey
2021-06-01 17:49 ` [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config Tim Harvey
2021-07-24 18:19 ` Tim Harvey
2021-07-26 1:01 ` Shawn Guo [this message]
2021-07-27 16:05 ` Tim Harvey
2021-06-01 17:49 ` [PATCH 3/4] arm64: dts: imx8mm-venice-gw7901: add support for USB hub subload Tim Harvey
2021-07-24 18:21 ` Tim Harvey
2021-06-01 17:49 ` [PATCH 4/4] arm64: dts: imx8mm-venice-gw7901: enable pull-down on gpio outputs Tim Harvey
2021-07-24 18:19 ` Tim Harvey
2021-06-02 7:10 ` [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp Frieder Schrempf
2021-06-04 15:42 ` Tim Harvey
2021-06-07 7:20 ` Frieder Schrempf
2021-06-07 7:30 ` Jacky Bai
2021-06-07 7:53 ` Frieder Schrempf
2021-06-07 8:00 ` Jacky Bai
2021-06-07 8:34 ` Frieder Schrempf
2021-06-11 18:55 ` Tim Harvey
2021-06-29 7:48 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726010139.GB5901@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).