From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9F5C4320A for ; Tue, 27 Jul 2021 05:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5549061131 for ; Tue, 27 Jul 2021 05:53:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235274AbhG0Fxg (ORCPT ); Tue, 27 Jul 2021 01:53:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235128AbhG0Fxf (ORCPT ); Tue, 27 Jul 2021 01:53:35 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B8AAC061760 for ; Mon, 26 Jul 2021 22:53:36 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8G1z-0005Y0-UG; Tue, 27 Jul 2021 07:53:31 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1m8G1x-00060v-Gs; Tue, 27 Jul 2021 07:53:29 +0200 Date: Tue, 27 Jul 2021 07:53:29 +0200 From: Oleksij Rempel To: alexandru.tachici@analog.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org Subject: Re: [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY Message-ID: <20210727055329.7y23ob7kir3te2e4@pengutronix.de> References: <20210712130631.38153-1-alexandru.tachici@analog.com> <20210712130631.38153-8-alexandru.tachici@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210712130631.38153-8-alexandru.tachici@analog.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:38:48 up 236 days, 19:45, 12 users, load average: 0.11, 0.08, 0.02 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 12, 2021 at 04:06:31PM +0300, alexandru.tachici@analog.com wrote: > From: Alexandru Tachici > > DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. > > Signed-off-by: Alexandru Tachici > --- > .../devicetree/bindings/net/adi,adin1100.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yaml > > diff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > new file mode 100644 > index 000000000000..14943164da7a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADIN1100 PHY > + > +maintainers: > + - Alexandru Tachici > + > +description: > + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +properties: > + adi,disable-2400mv-tx-level: > + description: > + Prevent ADIN1100 from using the 2.4 V pk-pk transmit level. > + type: boolean This property should be generic. It is defined by IEEE 802.3cg 2019 and can be implemented on all T1L PHYs. I assume, it should be something like: ethernet-phy-10base-t1l-2.4vpp-enable ethernet-phy-10base-t1l-2.4vpp-disable To overwrite bootstrapped of fuzed values if supported. The IEEE 802.3cg specification uses following wordings for this functionality: "10BASE-T1L increased transmit level request ..." "146.5.4.1 Transmitter output voltage When tested with the test fixture shown in Figure 146–20 with the transmitter in test mode 1, the transmitter output voltage shall be 2.4 V + 5%/ – 15% peak-to-peak (for the 2.4 Vpp operating mode) and 1.0 V + 5%/ – 15% peak-to-peak (for the 1.0 Vpp operating mode). Transmitter output voltage can be set using the management interface or by hardware default set-up." I would recommend to use similar wording if possible. > + > +unevaluatedProperties: false > + > +examples: > + - | > + ethernet@e000c000 { > + compatible = "cdns,zynq-gem", "cdns,gem"; > + reg = <0xe000c000 0x1000>; > + status = "okay"; > + phy-mode = "mii"; > + interrupts = <0 45 4>; > + clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; > + clock-names = "pclk", "hclk", "tx_clk"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@0 { > + reg = <0>; > + device_type = "ethernet-phy"; > + adi,disable-2400mv-tx-level; > + }; > + > + }; > -- > 2.25.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |