From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA84C433FE for ; Fri, 24 Sep 2021 10:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3B766105A for ; Fri, 24 Sep 2021 10:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245689AbhIXK7T (ORCPT ); Fri, 24 Sep 2021 06:59:19 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:53984 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245680AbhIXK7Q (ORCPT ); Fri, 24 Sep 2021 06:59:16 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id C9C9A40848 for ; Fri, 24 Sep 2021 10:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632481061; bh=JVVwsOf7X0M/+qlOsF+1zUq32C7aF6kWbgyKr7RQdek=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dhLOQ8V7F4wVe75i3PP2WCguFKDr6BjyNVv5ua9EHpsxQ1BlMFCYvRQd3O85uqBUA cnb6WqfLCe680LwJR2RFNeUhI1PFNGxQmKWiz3E07Rv4vYMqaNQbmS1BAE3dIKXFJR HbRUnLeDviteJ/Ce4NuJh6i9mGan0LOi+wn57RWVfgufBC8sRisGFCqAwn17/FrOyr YAv2pXqMWjqJQiXad8KOtHc9l+msV98PkaY9c2bTmS3WvA5iqOZe8bt/6CGdYjt6kr eAGxBuEA2tLvsMI216Cn8tt/q0svwZG5o0CDApg8AxRXb46Ps3sk//WrQHcoScIA2G CJMF7J18rY6CA== Received: by mail-wr1-f71.google.com with SMTP id v15-20020adff68f000000b0015df51efa18so7694677wrp.16 for ; Fri, 24 Sep 2021 03:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JVVwsOf7X0M/+qlOsF+1zUq32C7aF6kWbgyKr7RQdek=; b=ysZirCmohfrNtUqTMpFtZq895Et/YZzS5gHAvhyyfxL31HOzb+qSymww8c555F2v+9 UrRwU5ETsvIcDltm/qy5ALiysjHZvGX7DIQTpkXh21xQgMmUuQeJrUmE+vbjR+dK2V0Q Ne+hMFgv9tQF9BVibzx58UTo5zHB/KE56qw3bZMgf/UEnXrsif89HwaGG3BOWSdxnLaT GCqXGBIfVGTwn5fHmjMoS2L+uvAtzKBCqKTn250M8DELNfAim/qwyH3CMtXTFTsSfd7Z CoLnTg0a530LCsf5X7k5dt/BB91OfUUgjSYtX6m6/sPZsh+UTiKWjk20A0wq7SrXHjw/ uYcQ== X-Gm-Message-State: AOAM531JXDdGie5NlQd8I/XAZ84YT5Aw1pZKu4gKGRcWCArXYCB7kdfb BqbN4j4ionzQ32YOHDTPdHSvj09RnwLzGzNR5t0gDcdrF58A1JdfIKIeHdEBYNWgB2b95JYqvVj CF07cyMQutBtwip6KX2KrjiQSRIIaQgpex+11dmw= X-Received: by 2002:a05:6000:1a85:: with SMTP id f5mr10982714wry.25.1632481061424; Fri, 24 Sep 2021 03:57:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLYvzxMc9tP9qdmx2NxdiK+8VdwTUT+JMDAWIj2fLS9fniGFXTFwHyxW2JGc/QJ7sNrnQG5A== X-Received: by 2002:a05:6000:1a85:: with SMTP id f5mr10982699wry.25.1632481061305; Fri, 24 Sep 2021 03:57:41 -0700 (PDT) Received: from localhost.localdomain (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id x17sm8188836wrc.51.2021.09.24.03.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 03:57:40 -0700 (PDT) From: Krzysztof Kozlowski To: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Frank Rowand , Krzysztof Kozlowski , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() Date: Fri, 24 Sep 2021 12:56:53 +0200 Message-Id: <20210924105653.46963-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210924105653.46963-1-krzysztof.kozlowski@canonical.com> References: <20210924105653.46963-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The of_irq_parse_oldworld() does not modify passed device_node so make it a pointer to const for safety. Drop the extern while modifying the line. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Drop extern. --- arch/powerpc/platforms/powermac/pic.c | 2 +- include/linux/of_irq.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c index 4921bccf0376..af5ca1f41bb1 100644 --- a/arch/powerpc/platforms/powermac/pic.c +++ b/arch/powerpc/platforms/powermac/pic.c @@ -384,7 +384,7 @@ static void __init pmac_pic_probe_oldstyle(void) #endif } -int of_irq_parse_oldworld(struct device_node *device, int index, +int of_irq_parse_oldworld(const struct device_node *device, int index, struct of_phandle_args *out_irq) { const u32 *ints = NULL; diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h index aaf219bd0354..83fccd0c9bba 100644 --- a/include/linux/of_irq.h +++ b/include/linux/of_irq.h @@ -20,12 +20,12 @@ typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); #if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC) extern unsigned int of_irq_workarounds; extern struct device_node *of_irq_dflt_pic; -extern int of_irq_parse_oldworld(struct device_node *device, int index, - struct of_phandle_args *out_irq); +int of_irq_parse_oldworld(const struct device_node *device, int index, + struct of_phandle_args *out_irq); #else /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ #define of_irq_workarounds (0) #define of_irq_dflt_pic (NULL) -static inline int of_irq_parse_oldworld(struct device_node *device, int index, +static inline int of_irq_parse_oldworld(const struct device_node *device, int index, struct of_phandle_args *out_irq) { return -EINVAL; -- 2.30.2