From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dmaengine: sun6i: Add support for 34-bit physical addresses
Date: Mon, 22 Nov 2021 09:45:04 +0100 [thread overview]
Message-ID: <20211122084504.5picqz6xxaiup6tf@gilmour> (raw)
In-Reply-To: <20211119052702.14392-4-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi,
On Thu, Nov 18, 2021 at 11:27:00PM -0600, Samuel Holland wrote:
> @@ -645,7 +660,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy(
> if (!txd)
> return NULL;
>
> - v_lli = dma_pool_alloc(sdev->pool, GFP_NOWAIT, &p_lli);
> + v_lli = dma_pool_alloc(sdev->pool, GFP_DMA32|GFP_NOWAIT, &p_lli);
This raises a checkpatch --strict warning since we're supposed to have
spaces around the pipe.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-11-22 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 5:26 [PATCH 0/4] dmaengine: sun6i: Allwinner D1 support Samuel Holland
2021-11-19 5:26 ` [PATCH 1/4] dt-bindings: dma: sun50i-a64: Add compatible for D1 Samuel Holland
2021-11-29 23:13 ` Rob Herring
2021-11-19 5:26 ` [PATCH 2/4] dmaengine: sun6i: Do not use virt_to_phys Samuel Holland
2021-11-19 5:27 ` [PATCH 3/4] dmaengine: sun6i: Add support for 34-bit physical addresses Samuel Holland
2021-11-22 8:45 ` Maxime Ripard [this message]
2021-11-19 5:27 ` [PATCH 4/4] dmaengine: sun6i: Add support for the D1 variant Samuel Holland
2021-11-22 8:45 ` [PATCH 0/4] dmaengine: sun6i: Allwinner D1 support Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122084504.5picqz6xxaiup6tf@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).