devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tanmay Shah <tanmay.shah@xilinx.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ben Levinsky <ben.levinsky@xilinx.com>,
	Bill Mills <bill.mills@linaro.org>,
	Sergei Korneichuk <sergei.korneichuk@xilinx.com>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node
Date: Mon, 29 Nov 2021 10:58:03 -0700	[thread overview]
Message-ID: <20211129175803.GB676889@p14s> (raw)
In-Reply-To: <20211123062050.1442712-3-tanmay.shah@xilinx.com>

On Mon, Nov 22, 2021 at 10:20:46PM -0800, Tanmay Shah wrote:
> RPU subsystem can be configured in cluster-mode or split mode.
> Also each r5 core has separate power domains.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@xilinx.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 28dccb891a53..f4fb98ccb1b5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -654,6 +654,23 @@ qspi: spi@ff0f0000 {
>  			power-domains = <&zynqmp_firmware PD_QSPI>;
>  		};
>  
> +		r5fss: r5fss@ff9a0000 {
> +			compatible = "xlnx,zynqmp-r5fss";
> +			xlnx,cluster-mode = <1>;
> +
> +                        reg = <0x0 0Xff9a0000 0x0 0x228>;

This line is giving me an obvious checkpatch warning.  Please make sure you run
checkpatch.pl before sending out a patchset.

> +
> +			r5f_core0: r5f-0 {
> +				compatible = "xlnx,zynqmp-r5f";
> +				power-domains = <&zynqmp_firmware PD_RPU_0>;
> +			};
> +
> +			r5f_core1: r5f-1 {
> +				compatible = "xlnx,zynqmp-r5f";
> +				power-domains = <&zynqmp_firmware PD_RPU_1>;
> +			};
> +		};
> +
>  		psgtr: phy@fd400000 {
>  			compatible = "xlnx,zynqmp-psgtr-v1.1";
>  			status = "disabled";
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-11-29 22:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23  6:20 [PATCH v2 0/6] Add Xilinx RPU subsystem support Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Tanmay Shah
2021-11-29 17:58   ` Mathieu Poirier [this message]
2021-11-30  8:01     ` Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 3/6] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 4/6] firmware: xilinx: Add shutdown/wakeup APIs Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 5/6] firmware: xilinx: Add RPU configuration APIs Tanmay Shah
2021-11-23  6:20 ` [PATCH v2 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Tanmay Shah
2021-11-29 18:42   ` Mathieu Poirier
2021-11-30  8:01     ` Tanmay Shah
2021-11-30 20:14       ` Mathieu Poirier
2021-12-01 18:37         ` Tanmay Shah
2021-12-03 18:55   ` Mathieu Poirier
2021-12-06 11:03     ` Tanmay Shah
2021-12-13  8:10     ` Tanmay Shah
2021-12-13 18:39       ` Mathieu Poirier
2021-12-06 19:04   ` Mathieu Poirier
2021-12-13 19:11     ` Tanmay Shah
2021-12-07 18:31   ` Mathieu Poirier
2021-12-13 19:17     ` Tanmay Shah
2022-02-07 18:57     ` Tanmay Shah
2022-02-08 16:54       ` Mathieu Poirier
2022-02-09 10:23         ` Tanmay Shah
2021-12-13 11:08   ` Lars-Peter Clausen
2021-12-13 19:31     ` Tanmay Shah
2021-12-13 19:43       ` Lars-Peter Clausen
2021-12-13 19:46         ` Tanmay Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129175803.GB676889@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=ben.levinsky@xilinx.com \
    --cc=bill.mills@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.korneichuk@xilinx.com \
    --cc=tanmay.shah@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).