From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20719C433EF for ; Fri, 3 Dec 2021 13:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381234AbhLCNxy (ORCPT ); Fri, 3 Dec 2021 08:53:54 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:45445 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381255AbhLCNxv (ORCPT ); Fri, 3 Dec 2021 08:53:51 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 17E32580295; Fri, 3 Dec 2021 08:50:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 Dec 2021 08:50:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=akxh18q/9FuvUwVb7rrBtJj3NXJ qPeKLLTOAQ2VJUIQ=; b=E7QA6va/ODxxan6vWieR2bwBdEIUHq7Kf+abT7KsSig 4/4p9Yn5u//NkG5/vzhkoeEhF1pQltG6miFk9x4en/4O0mzJB6FlnNlde+OkoXVy oCc9tFvgjlrAoSRW6nzJUs0liTVV3kYbdX/Mj10ltmffwgxP4djJCSpJAYRo23n/ sW89zGCUx/2YTs1mno1LL/EhAyUsS0XltonExj4tf9dSjAzXjh10P62UditIxomm uaUykjsf82mLSDgVIwrJmy+u29r3pTEyo4DgbeWZjFU6UlkInPHdgCG+YG8VfHuG 81zGbaJmVC7u3C/n3jYiuqLmH0iayLjUPteqzg3DJAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=akxh18 q/9FuvUwVb7rrBtJj3NXJqPeKLLTOAQ2VJUIQ=; b=Idg3YLCARZnnctOADGP+P0 iGwYvMLahclfsoddlBJ3kLeDvsEMl68gfbPHYTztzkVNafHj+SW2sFiDQ8OV26y7 eYjm27xBLI/CqTmy2JjT1Cqk00TgH6UKpfVB2anenA+v683YG2hE1wABrGwJXJI3 /JGfBWijuA+GeX3G6K5dOx1K+u19g0d+d9QAaJfJkk9PwTuvgg3U4ig6Jy8kTH9L nZ+J02k/jhE2esdGW9HT+Zo80kRIy2qEkdcz7AVF0pT+0aqqTPJLrgAe5Rjv7+9F fjZ2AJ92V9U7pLkY91iVTJCKa2JRrZ9DGB/6/G/SP+dDSlfC7F2kz0uY8c6UsiLw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieejgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Dec 2021 08:50:25 -0500 (EST) Date: Fri, 3 Dec 2021 14:50:23 +0100 From: Maxime Ripard To: nicolas saenz julienne Cc: Scott Branden , Rob Herring , Frank Rowand , Ray Jui , Florian Fainelli , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline Message-ID: <20211203135023.sbj4uxwsaoeakfjj@houat> References: <20211117145040.334827-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o2ikn7rqgar5nz4m" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --o2ikn7rqgar5nz4m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nicolas, On Tue, Nov 30, 2021 at 12:45:49PM +0100, nicolas saenz julienne wrote: > On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote: > > The VC4 driver has had limited support to disable the HDMI controllers = and > > pixelvalves at boot if the firmware has enabled them. > >=20 > > However, this proved to be limited, and a bit unreliable so a new firmw= are > > command has been introduced some time ago to make it free all its resou= rces and > > disable any display output it might have enabled. > >=20 > > This series takes advantage of that command to call it once the transit= ion from > > simplefb to the KMS driver has been done. >=20 > I think it would make sense to integrate this funtionality into > 'reset/reset-raspberrypi.c' and pass it to VC4 as a reset controller. It = fits > the same startup situation as the one we have with the USB controller. Al= so, it > would contain the firmware weirdness in a single spot. I don't really think it makes sense. It's not really made for that purpose, affects multiple devices (basically, all of the devices from the display pipeline), and can even have some side effects on clocks and memory. Plus, it can only be done once iirc, so a later call to reset the pipeline will be ineffective, even if we changed its state. So yeah, it doesn't really fit into the reset abstraction. > Otherwise, please use 'devm_rpi_firmware_get()'. Will do, thanks! Maxime --o2ikn7rqgar5nz4m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYaognwAKCRDj7w1vZxhR xfE0AP47WTZwzJ3tx6UI2x9jdCgNkdqfPqY9KklclX/AmO1XjAD/eU5lLomwBy1e NIXKZaV72SSlVI+jlzoLNNyYMyHUOAM= =vVMw -----END PGP SIGNATURE----- --o2ikn7rqgar5nz4m--