From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
<linux-mtd@lists.infradead.org>, Mark Brown <broonie@kernel.org>,
<linux-spi@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Xiangsheng Hou <Xiangsheng.Hou@mediatek.com>,
Julien Su <juliensu@mxic.com.tw>,
Jaime Liao <jaimeliao@mxic.com.tw>,
Boris Brezillon <boris.brezillon@collabora.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v3 00/22] External ECC engines & Macronix support
Date: Tue, 7 Dec 2021 10:34:00 +0100 [thread overview]
Message-ID: <20211207093422.166934-1-miquel.raynal@bootlin.com> (raw)
Hello all,
~~~
Mark, I've added your Reviewed-by on all the SPI related patches, please
check and tell me if I made a mistake. In particular, I've added
something since v2: the spi-mxic.c driver now also depends on
MTD_NAND_ECC in order to avoid faulty situations where MTD/NAND=m and
SPI=y. Let me know if this does not work for you.
~~~
This series is now stable and brings support for external/modular ECC
engines, and let SPI controller using the ECC framework.
As a first example, Macronix ECC engine can be used as an
external engine (takes the data, proceeds to the calculations, writes
back the ECC bytes) or as a pipelined engine doing on-the-fly
calculations (which is very common in the raw NAND world).
In the device tree, the ECC engine should be described as a separated DT
node. Then:
* external case: the flash node should provide a nand-ecc-engine
property pointing to the ECC engine node.
* pipelined case: the flash node should provide a nand-ecc-engine
property pointing to the SPI controller, itself with another
nand-ecc-engine property pointing at the ECC engine node.
This series comes with a bunch of improvements on the binding side as
well.
Cheers,
Miquèl
Changes in v3:
* Added Mark's R-by.
* Added a commit changing the initialization order between the dirmaps
and the ECC engine so that the core might now if we are using a
pipelined engine or not.
* Stopped creating additional dirmaps with ECC if the engine is not a
pipelined engine.
* Solved the kernel test robot reports. In particular, I added a
dependency on MTD_NAND_ECC to Macronix SPI controller driver.
* Added a patch to clean the NAND controller yaml file before moving
some bits to nand-chip.yaml. This addresses the comments made by Rob
about the useless allOf's.
* Used platform_get_irq_byname_optional() in order to avoid useless
warnings when there is no IRQ.
Changes in v2:
* Fixed the bindings and added Rob's acks when relevant.
* Added locking in the ECC engine driver.
* Brought more changes in the core in order to bring the ECC information
into the spi_mem_op structure with the idea of avoiding any races
between parallel calls on the same engine.
* Reorganized the ECC driver entirely in order to have a per-engine mxic
structure plus a per-NAND context. This lead to a number of changes
internally which cannot all be listed.
Changes since the RFC:
* Rebased on top of v5.15-rc1.
* Fixed the dirmap configuration.
* Added the various tags received.
* Fixed the bindings as reported by the robots.
* Fixed the return value of the helper counting bitflips.
* Included a fix from Jaime Liao in the external pattern logic.
* Added the yaml conversion of Macronix SPI controller description.
* Added the yaml conversion of the SPI-NAND description.
* Created a nand-chip.yaml file to share properties between SPI-NAND and
raw NAND.
Mason Yang (1):
mtd: spinand: macronix: Use random program load
Miquel Raynal (21):
dt-bindings: mtd: nand-controller: Fix the reg property description
dt-bindings: mtd: nand-controller: Fix a comment in the examples
dt-bindings: mtd: nand-controller: Harmonize the property types
dt-bindings: mtd: nand-chip: Create a NAND chip description
dt-bindings: mtd: spi-nand: Convert spi-nand description file to yaml
dt-bindings: vendor-prefixes: Clarify Macronix prefix
dt-bindings: spi: mxic: The interrupt property is not mandatory
dt-bindings: spi: mxic: Convert to yaml
dt-bindings: spi: mxic: Document the nand-ecc-engine property
dt-bindings: mtd: Describe Macronix NAND ECC engine
mtd: nand: ecc: Add infrastructure to support hardware engines
mtd: nand: Add a new helper to retrieve the ECC context
mtd: nand: mxic-ecc: Add Macronix external ECC engine support
mtd: nand: mxic-ecc: Support SPI pipelined mode
mtd: spinand: Delay a little bit dirmap creation
mtd: spinand: Create direct mapping descriptors for ECC operations
spi: mxic: Fix the transmit path
spi: mxic: Create a helper to configure the controller before an
operation
spi: mxic: Create a helper to ease the start of an operation
spi: mxic: Add support for direct mapping
spi: mxic: Add support for pipelined ECC operations
.../bindings/mtd/mxicy,nand-ecc-engine.yaml | 77 ++
.../devicetree/bindings/mtd/nand-chip.yaml | 70 ++
.../bindings/mtd/nand-controller.yaml | 62 +-
.../devicetree/bindings/mtd/spi-nand.txt | 5 -
.../devicetree/bindings/mtd/spi-nand.yaml | 27 +
.../bindings/spi/mxicy,mx25f0a-spi.yaml | 66 ++
.../devicetree/bindings/spi/spi-mxic.txt | 34 -
.../devicetree/bindings/vendor-prefixes.yaml | 3 +
drivers/mtd/nand/Kconfig | 6 +
drivers/mtd/nand/Makefile | 1 +
drivers/mtd/nand/core.c | 10 +-
drivers/mtd/nand/ecc-mxic.c | 900 ++++++++++++++++++
drivers/mtd/nand/ecc.c | 88 ++
drivers/mtd/nand/spi/core.c | 51 +-
drivers/mtd/nand/spi/macronix.c | 2 +-
drivers/spi/Kconfig | 2 +-
drivers/spi/spi-mxic.c | 326 ++++++-
include/linux/mtd/nand-ecc-mxic.h | 49 +
include/linux/mtd/nand.h | 33 +
include/linux/mtd/spinand.h | 2 +
include/linux/spi/spi-mem.h | 3 +
21 files changed, 1656 insertions(+), 161 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mtd/mxicy,nand-ecc-engine.yaml
create mode 100644 Documentation/devicetree/bindings/mtd/nand-chip.yaml
delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
create mode 100644 Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
delete mode 100644 Documentation/devicetree/bindings/spi/spi-mxic.txt
create mode 100644 drivers/mtd/nand/ecc-mxic.c
create mode 100644 include/linux/mtd/nand-ecc-mxic.h
--
2.27.0
next reply other threads:[~2021-12-07 9:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 9:34 Miquel Raynal [this message]
2021-12-07 9:34 ` [PATCH v3 01/22] dt-bindings: mtd: nand-controller: Fix the reg property description Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 02/22] dt-bindings: mtd: nand-controller: Fix a comment in the examples Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 03/22] dt-bindings: mtd: nand-controller: Harmonize the property types Miquel Raynal
2021-12-14 17:45 ` Rob Herring
2021-12-15 15:50 ` Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 04/22] dt-bindings: mtd: nand-chip: Create a NAND chip description Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 05/22] dt-bindings: mtd: spi-nand: Convert spi-nand description file to yaml Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 06/22] dt-bindings: vendor-prefixes: Clarify Macronix prefix Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 07/22] dt-bindings: spi: mxic: The interrupt property is not mandatory Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 08/22] dt-bindings: spi: mxic: Convert to yaml Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 09/22] dt-bindings: spi: mxic: Document the nand-ecc-engine property Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 10/22] dt-bindings: mtd: Describe Macronix NAND ECC engine Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 11/22] mtd: spinand: macronix: Use random program load Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 12/22] mtd: nand: ecc: Add infrastructure to support hardware engines Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 13/22] mtd: nand: Add a new helper to retrieve the ECC context Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 14/22] mtd: nand: mxic-ecc: Add Macronix external ECC engine support Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 15/22] mtd: nand: mxic-ecc: Support SPI pipelined mode Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 16/22] mtd: spinand: Delay a little bit dirmap creation Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 17/22] mtd: spinand: Create direct mapping descriptors for ECC operations Miquel Raynal
2021-12-07 9:46 ` Boris Brezillon
2021-12-07 10:53 ` Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 18/22] spi: mxic: Fix the transmit path Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 19/22] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 20/22] spi: mxic: Create a helper to ease the start of " Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 21/22] spi: mxic: Add support for direct mapping Miquel Raynal
2021-12-07 9:34 ` [PATCH v3 22/22] spi: mxic: Add support for pipelined ECC operations Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207093422.166934-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=Xiangsheng.Hou@mediatek.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jaimeliao@mxic.com.tw \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).