From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
Holger Brunck <holger.brunck@hitachienergy.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH devicetree 2/2] dt-bindings: phy: Add `tx-amplitude-microvolt` property binding
Date: Wed, 15 Dec 2021 18:22:22 +0100 [thread overview]
Message-ID: <20211215182222.620606a0@thinkpad> (raw)
In-Reply-To: <YbnJhI2Z3lwC3vF9@lunn.ch>
On Wed, 15 Dec 2021 11:55:00 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Dec 15, 2021 at 12:34:32AM +0100, Marek Behún wrote:
> > Common PHYs often have the possibility to specify peak-to-peak voltage
> > on the differential pair - the default voltage sometimes needs to be
> > changed for a particular board.
>
> Hi Marek
>
> Common PHYs are not the only user of this. Ethernet PHYs can also use
> it, as well as SERDESes embedded within Ethernet switches.
>
> That is why i suggested these properties go into something like
> serdes.yaml. That can then be included into Common PHY, Ethernet PHYs,
> switch drivers etc.
>
> Please could you make such a split?
>
> Andrew
Hi Andrew,
and where (into which directory) should this serdes.yaml file go?
My idea was to put the properties into common PHY and then refer to
them from other places, so for example this would be put into ethernet
PHY binding:
serdes-tx-amplitude-microvolt:
$ref: '/schemas/phy/phy.yaml#/properties/tx-amplitude-microvolt'
Marek
next prev parent reply other threads:[~2021-12-15 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 23:34 [PATCH devicetree 0/2] Common PHY to YAML + tx-amplitude property Marek Behún
2021-12-14 23:34 ` [PATCH devicetree 1/2] dt-bindings: phy: Convert generic PHY provider binding to YAML Marek Behún
2021-12-15 21:41 ` Rob Herring
2021-12-14 23:34 ` [PATCH devicetree 2/2] dt-bindings: phy: Add `tx-amplitude-microvolt` property binding Marek Behún
2021-12-15 10:55 ` Andrew Lunn
2021-12-15 17:22 ` Marek Behún [this message]
2021-12-15 17:29 ` Andrew Lunn
2021-12-15 22:01 ` Rob Herring
2021-12-15 21:58 ` Rob Herring
2022-01-12 17:29 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215182222.620606a0@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=holger.brunck@hitachienergy.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).