From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH 3/8] mfd: axp20x: probe axp20x_adc driver for AXP813 Date: Thu, 7 Dec 2017 09:51:29 +0100 Message-ID: <2021a653-d01e-f46f-2438-0760f579e0dc@free-electrons.com> References: <302c93023d8c4a54cafe321d912df484e39727b7.1512396054.git-series.quentin.schulz@free-electrons.com> <20171205080855.arr7vlgnxoxmyedd@flea.lan> Reply-To: quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CKe7BMNQHPDOaBDUGGk5sXG7SusBOD6rT" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20171205080855.arr7vlgnxoxmyedd-ZC1Zs529Oq4@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CKe7BMNQHPDOaBDUGGk5sXG7SusBOD6rT Content-Type: multipart/mixed; boundary="L8Vm8d4SIciBN1MfClM1D85tcCuLeDfav"; protected-headers="v1" From: Quentin Schulz To: Maxime Ripard Cc: sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Message-ID: <2021a653-d01e-f46f-2438-0760f579e0dc-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Subject: Re: [PATCH 3/8] mfd: axp20x: probe axp20x_adc driver for AXP813 References: <302c93023d8c4a54cafe321d912df484e39727b7.1512396054.git-series.quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> <20171205080855.arr7vlgnxoxmyedd-ZC1Zs529Oq4@public.gmane.org> In-Reply-To: <20171205080855.arr7vlgnxoxmyedd-ZC1Zs529Oq4@public.gmane.org> --L8Vm8d4SIciBN1MfClM1D85tcCuLeDfav Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Hi Maxime, On 05/12/2017 09:08, Maxime Ripard wrote: > On Mon, Dec 04, 2017 at 03:12:49PM +0100, Quentin Schulz wrote: >> This makes the axp20x_adc driver probe with platform device id >> "axp813-adc". >> >> Signed-off-by: Quentin Schulz >> --- >> drivers/mfd/axp20x.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 2468b43..42e54d1 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -878,7 +878,9 @@ static struct mfd_cell axp813_cells[] = { >> .resources = axp803_pek_resources, >> }, { >> .name = "axp20x-regulator", >> - } >> + }, { >> + .name = "axp813-adc", >> + }, > > Any particular reason you're not adding it to the DT? > No, no particular reason. It's just the way it is currently for AXP209 and AXP22x so did the same for AXP813. I'll add DT "support" in next version for all AXPs supported by this driver. Or is it worthy of a small separate patch series? Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --L8Vm8d4SIciBN1MfClM1D85tcCuLeDfav-- --CKe7BMNQHPDOaBDUGGk5sXG7SusBOD6rT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJaKQEfAAoJEIS4mnU+4PGjl7wQAKV051f4Ogq8VT/6GjoD0HTq 6BVWQ6noHHW+mGZJBdQ8bSsa+oLjA/UbOPraZUdUn6tiiNWVsuGji3N0LpJPnlQC 8pIGLrC3A4arFGlHEgZCPTdvvwnKcE2lu9RxWbY38GHAvWIcZyOK7G5s2KUOlmpC 6TecdVq6JjSIETVch5syOYA9/x5WfS1tiquOGDbCOJs3+SlUe/WVLnm7QZ6zJVcs 8OFl2cjJFOaArVCwRih2sECMRGbn9Y7h/wdXkTcW4obmtkzV84xjx5pKrWcoof2l X+Uv0jVgZhlto1FhrUfajwE/Xj90r4vchfJJFjUF/FWVIJ09REqlkIxLhnjlf7iI otyPRi3RGtR3CO0A1LwKmR8+IlIgq214c/foBhMcLOyDAneHdW7DdWyWOfba7aqt vUXOvETU9isCdCV6d8FvydqHpdJqpXnJhjX9YeYU8f+2hYginFdd7maN1UVZb03K eaiFbYD3zbvguSCVVlHbvhfy84Uvo0qyVN/fDwH8vGNXjhFYwDKw0AA4BqJWiWOM OE3req92nrSeEZYUakoW0kwdVjbRd2UdC7BEiPH4SOw4ZhZiUv6lxdT6nNoO+xWA Z8T4WtrSPnK74tAEIZoTzhGncK3kAMESyouh/lpPkCpghPu9HHGx8351zLmynkNc 6WYdwKKAF5oLo6OZEhd1 =bEdh -----END PGP SIGNATURE----- --CKe7BMNQHPDOaBDUGGk5sXG7SusBOD6rT--