From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Chanho Park <chanho61.park@samsung.com>,
Alim Akhtar <alim.akhtar@gmail.com>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH v2 05/28] ARM: dts: exynos: override pins by label in Peach Pit
Date: Tue, 11 Jan 2022 21:14:03 +0100 [thread overview]
Message-ID: <20220111201426.326777-6-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20220111201426.326777-1-krzysztof.kozlowski@canonical.com>
Using node paths to extend or override a device tree node is error
prone. If there was a typo error, a new node will be created instead of
extending the existing node. This will lead to run-time errors that
could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error
(during build time).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++-----------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index e76fb104db19..1ae5528e9ebf 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 {
};
};
-&pinctrl_1 {
- /* Adjust WiFi drive strengths lower for EMI */
- sd1_clk: sd1-clk {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+/* pinctrl_1 */
+/* Adjust WiFi drive strengths lower for EMI */
+&sd1_bus1 {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
- sd1_cmd: sd1-cmd {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+&sd1_bus4 {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
- sd1_bus1: sd1-bus-width1 {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+&sd1_bus8 {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
- sd1_bus4: sd1-bus-width4 {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+&sd1_clk {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
- sd1_bus8: sd1-bus-width8 {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+&sd1_cmd {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
};
&pinctrl_2 {
@@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 {
};
};
-&pinctrl_3 {
- /* Drive SPI lines at x2 for better integrity */
- spi2-bus {
- samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
- };
+/* pinctrl_3*/
+/* Drive SPI lines at x2 for better integrity */
+&spi2_bus {
+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
+};
+&pinctrl_3 {
/* Drive SPI chip select at x2 for better integrity */
ec_spi_cs: ec-spi-cs {
samsung,pins = "gpb1-2";
--
2.32.0
next prev parent reply other threads:[~2022-01-11 20:15 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 20:13 [PATCH v2 00/28] pinctrl: dt-bindings: samsung: convert to dtschema Krzysztof Kozlowski
2022-01-11 20:13 ` [PATCH v2 01/28] pinctrl: samsung: drop pin banks references on error paths Krzysztof Kozlowski
2022-01-12 5:28 ` Chanho Park
2022-01-14 16:38 ` Sam Protsenko
2022-01-11 20:14 ` [PATCH v2 02/28] pinctrl: samsung: accept GPIO bank nodes with a suffix Krzysztof Kozlowski
2022-01-14 17:00 ` Sam Protsenko
2022-01-11 20:14 ` [PATCH v2 03/28] ARM: dts: exynos: drop unused pinctrl defines in Exynos3250 Krzysztof Kozlowski
2022-01-11 20:14 ` [PATCH v2 04/28] ARM: dts: exynos: simplify PMIC DVS pin configuration in Odroid XU Krzysztof Kozlowski
2022-01-11 20:14 ` Krzysztof Kozlowski [this message]
2022-01-11 20:14 ` [PATCH v2 06/28] ARM: dts: exynos: simplify PMIC DVS pin configuration in Peach Pit Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 07/28] ARM: dts: exynos: override pins by label in Peach Pi Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 08/28] ARM: dts: exynos: simplify PMIC DVS pin configuration " Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 09/28] ARM: dts: s3c64xx: drop unneeded pinctrl wake-up interrupt mapping Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 10/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos3250 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 11/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos4210 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 12/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos4412 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 13/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos5250 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 14/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos5260 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 15/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos5410 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 16/28] ARM: dts: exynos: align pinctrl with dtschema in Exynos542x/5800 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 17/28] arm64: dts: exynos: align pinctrl with dtschema in Exynos5433 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 18/28] arm64: dts: exynos: align pinctrl with dtschema in Exynos7 Krzysztof Kozlowski
2022-01-16 15:34 ` Alim Akhtar
2022-01-11 20:17 ` [PATCH v2 19/28] arm64: dts: exynos: align pinctrl with dtschema in Exynos850 Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 20/28] arm64: dts: exynos: align pinctrl with dtschema in ExynosAutov9 Krzysztof Kozlowski
2022-01-12 5:21 ` Chanho Park
2022-01-14 16:40 ` Sam Protsenko
2022-01-11 20:17 ` [PATCH v2 21/28] ARM: dts: s3c24xx: align pinctrl with dtschema Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 22/28] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 23/28] ARM: dts: s5pv210: " Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 24/28] dt-bindings: pinctrl: samsung: convert to dtschema Krzysztof Kozlowski
2022-01-16 0:55 ` Linus Walleij
2022-01-16 17:10 ` Krzysztof Kozlowski
2022-01-16 21:38 ` Linus Walleij
2022-01-17 7:45 ` Krzysztof Kozlowski
2022-01-17 20:26 ` Olof Johansson
2022-01-18 7:52 ` Krzysztof Kozlowski
2022-01-11 20:17 ` [PATCH v2 25/28] dt-bindings: pinctrl: samsung: describe Exynos850 and ExynosAutov9 wake-ups Krzysztof Kozlowski
2022-01-12 2:26 ` Rob Herring
2022-01-14 19:44 ` Sam Protsenko
2022-01-11 20:17 ` [PATCH v2 26/28] pinctrl: samsung: add support for " Krzysztof Kozlowski
2022-01-12 5:21 ` Chanho Park
2022-01-14 16:39 ` Sam Protsenko
2022-01-11 20:17 ` [PATCH v2 27/28] arm64: dts: exynos: use dedicated wake-up pinctrl compatible in Exynos850 Krzysztof Kozlowski
2022-01-14 18:34 ` Sam Protsenko
2022-01-11 20:17 ` [PATCH v2 28/28] arm64: dts: exynos: use dedicated wake-up pinctrl compatible in ExynosAutov9 Krzysztof Kozlowski
2022-01-12 5:28 ` Chanho Park
2022-01-14 16:31 ` Sam Protsenko
2022-01-14 18:31 ` [PATCH v2 00/28] pinctrl: dt-bindings: samsung: convert to dtschema Sam Protsenko
2022-01-15 15:46 ` Krzysztof Kozlowski
2022-01-23 11:46 ` Krzysztof Kozlowski
2022-01-23 17:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111201426.326777-6-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alim.akhtar@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).