Hi,

On Wed, Jan 12, 2022 at 10:37:55AM +0800, Conley Lee wrote:
> On 01/11/22 at 11:35上午, Maxime Ripard wrote:
> > Date: Tue, 11 Jan 2022 11:35:42 +0100
> > From: Maxime Ripard <maxime@cerno.tech>
> > To: conleylee@foxmail.com
> > Cc: robh@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
> >  linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20
> >  support
> > 
> > Hi,
> > 
> > On Wed, Jan 05, 2022 at 10:45:50AM +0800, conleylee@foxmail.com wrote:
> > > From: conley <conleylee@foxmail.com>
> > 
> > This should be your full name in the author and signed-off-by
> > 
> > > ARM dts: sun7i: Add Marsboard A20 board
> > > 
> > > This patch add support for Marsboard A20 board.
> > > 
> > > The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> > > card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> > > USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> > > 
> > > Change since v1.
> > >   - Spearate biddings and dts as two patches.
> > >   - use SPDX tag
> > 
> > And the changelog should be after the --- below
> > 
> > > Signed-off-by: conley <conleylee@foxmail.com>
> > > ---
> > >  arch/arm/boot/dts/Makefile                |   1 +
> > >  arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++++
> > >  2 files changed, 184 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > > index 0de64f237cd8..4628a2617313 100644
> > > --- a/arch/arm/boot/dts/Makefile
> > > +++ b/arch/arm/boot/dts/Makefile
> > > @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> > >  	sun7i-a20-icnova-swac.dtb \
> > >  	sun7i-a20-lamobo-r1.dtb \
> > >  	sun7i-a20-linutronix-testbox-v2.dtb \
> > > +	sun7i-a20-marsboard.dtb \
> > >  	sun7i-a20-m3.dtb \
> > >  	sun7i-a20-mk808c.dtb \
> > >  	sun7i-a20-olimex-som-evb.dtb \
> > > diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > new file mode 100644
> > > index 000000000000..7ab6aa30fee6
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > @@ -0,0 +1,183 @@
> > > +// SPDX-License-Identifier: LGPL-2.1+
> > 
> > The license for DT files is usually a dual-license with GPL and MIT,
> > which would be:
> > 
> > SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > 
> > You can't link to a DT, so GPL and LGPL should be equivalent here, and
> > MIT is useful for other projects (like the *BSD) that reuse the DT.
> > 
> > > +/*
> > > + * Copyright 2021 Conley Lee
> > > + * Conley Lee <conleylee@foxmail.com>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun7i-a20.dtsi"
> > > +#include "sunxi-common-regulators.dtsi"
> > > +
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +
> > > +/ {
> > > +	model = "HAOYU Electronics Marsboard A20";
> > > +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> > 
> > Is there multiple boards called marsboard?
> > 
> > If not, then the compatible should be haoyu,marsboard.
> > 
> > The file name should be sun7i-a20-haoyu-marsboard too.
> > 
> > > +	aliases {
> > > +		serial0 = &uart0;
> > > +	};
> > > +
> > > +	chosen {
> > > +		stdout-path = "serial0:115200n8";
> > > +	};
> > > +
> > > +	hdmi-connector {
> > > +		compatible = "hdmi-connector";
> > > +		type = "a";
> > > +
> > > +		port {
> > > +			hdmi_con_in: endpoint {
> > > +				remote-endpoint = <&hdmi_out_con>;
> > > +			};
> > > +		};
> > > +	};
> > > +};
> > > +
> > > +&ahci {
> > > +	target-supply = <&reg_ahci_5v>;
> > > +	status = "okay";
> > > +};
> > > +
> > > +&codec {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&cpu0 {
> > > +	cpu-supply = <&reg_dcdc2>;
> > > +};
> > > +
> > > +&de {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ehci0 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ehci1 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&gmac_mii_pins {
> > > +	pins = "PA0", "PA1", "PA2",
> > > +	"PA3", "PA4", "PA5", "PA6",
> > > +	"PA7", "PA8", "PA9", "PA10",
> > > +	"PA11", "PA12", "PA13", "PA14",
> > > +	"PA15", "PA16", "PA17";
> > > +};
> > 
> > Why do you need that node?
>
> 1. There are two boards called marsboard, another one is based on
>    sun4i-a10.

Ok

> 2. About the gmac_mii_pins node: the pin PA17 is connected to PHY
>    as EXTERR signal on sun7i-a20-marsboard, it's different from 
>    the definetion in dtsi.

The A20-Olinuxino-Micro has the same thing then, please do it like they did.

Maxime