From: Jonathan Cameron <jic23@kernel.org>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Maxime Ripard <maxime@cerno.tech>, Chen-Yu Tsai <wens@csie.org>,
linux-sunxi@lists.linux.dev, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40
Date: Sat, 15 Jan 2022 15:41:07 +0000 [thread overview]
Message-ID: <20220115154052.51634f37@jic23-huawei> (raw)
In-Reply-To: <85db7e8a-2b9a-7e44-ec96-b804201a3491@wirenboard.com>
On Tue, 11 Jan 2022 16:13:02 +0300
Evgeny Boger <boger@wirenboard.com> wrote:
> 22.11.2021 15:41, Jonathan Cameron пишет:
> > On Mon, 22 Nov 2021 10:11:32 +0100
> > Maxime Ripard <maxime@cerno.tech> wrote:
> >
> >> On Fri, Nov 19, 2021 at 10:14:54PM +0300, Evgeny Boger wrote:
> >>> R40 SoC has touchscreen controller also serving as general-purpose ADC.
> >>> The hardware is very similar to A31, except that R40 has separate
> >>> calibrated thermal sensor IP (handled by sun8i_thermal).
> >>>
> >>> Despite the temperature sensor in the RTP is never mentioned in
> >>> the R40 family user manuals, it appears to be working. However,
> >>> it's not very useful as it lacks calibration data and there is another
> >>> fully functioning temperature sensor anyway.
> >>>
> >>> This patch disables the temperature sensor in RTP/GPADC IP on R40.
> >>>
> >>> The reason for disabling the temperature sensor is that the IP
> >>> needs to be switched back and forth between RTP and GPADC modes for
> >>> temperature measurements. Not only this introduces delays, but it also
> >>> disturbs external circuitry by injecting current into ADC inputs.
> >>>
> >>> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> >> Acked-by: Maxime Ripard <maxime@cerno.tech>
> > +Cc linux-iio@vger.kernel.org
> >
> > I'm fine with this and assuming Lee is happy to pick it up + send
> > me an immutable branch in case anything crosses with it this cycle..
> >
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Hi Jonathan!
>
> Is there anything else I should do to make this patch series accepted?
Perhaps try a resend to Lee Jones, making sure to cc linux-iio
Chances are it just got missed in the deluge!
Jonathan
>
>
> > Thanks,
> >
> > Jonathan
> >
> >> Maxime
> >>
>
next prev parent reply other threads:[~2022-01-15 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:14 [PATCH 0/3] Enable RTP (GPADC) controller on Allwinner R40 Evgeny Boger
2021-11-19 19:14 ` [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40 Evgeny Boger
2021-11-22 9:11 ` Maxime Ripard
2021-11-22 12:41 ` Jonathan Cameron
2022-01-11 13:13 ` Evgeny Boger
2022-01-15 15:41 ` Jonathan Cameron [this message]
2022-01-17 9:00 ` Lee Jones
2021-11-19 19:14 ` [PATCH 2/3] dt-bindings: iio: adc: new compatible for Allwinner R40 RTP controller Evgeny Boger
2021-11-22 9:10 ` Maxime Ripard
2021-11-30 1:46 ` Rob Herring
2021-11-19 19:14 ` [PATCH 3/3] ARM: dts: sun8i: r40: add rtp node Evgeny Boger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115154052.51634f37@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=boger@wirenboard.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).